net/mlx4: Fix error check for dma_map_sg
authorJack Wang <jinpu.wang@ionos.com>
Thu, 25 Aug 2022 06:35:33 +0000 (08:35 +0200)
committerJakub Kicinski <kuba@kernel.org>
Sat, 27 Aug 2022 00:29:50 +0000 (17:29 -0700)
dma_map_sg return 0 on error.

Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Link: https://lore.kernel.org/r/20220825063533.21015-1-jinpu.wang@ionos.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/mellanox/mlx4/icm.c

index d89a3da..59b8b3c 100644 (file)
@@ -208,7 +208,7 @@ struct mlx4_icm *mlx4_alloc_icm(struct mlx4_dev *dev, int npages,
                                                chunk->sg, chunk->npages,
                                                DMA_BIDIRECTIONAL);
 
-                       if (chunk->nsg <= 0)
+                       if (!chunk->nsg)
                                goto fail;
                }
 
@@ -222,7 +222,7 @@ struct mlx4_icm *mlx4_alloc_icm(struct mlx4_dev *dev, int npages,
                chunk->nsg = dma_map_sg(&dev->persist->pdev->dev, chunk->sg,
                                        chunk->npages, DMA_BIDIRECTIONAL);
 
-               if (chunk->nsg <= 0)
+               if (!chunk->nsg)
                        goto fail;
        }