gst/gstvalue.c: check that a simple string that gets deserialized does not contain...

Original commit message from CVS:
* gst/gstvalue.c: (gst_value_deserialize_string):
check that a simple string that gets deserialized does not contain
invalid characters
* testsuite/caps/value_serialize.c: (test_string_deserialization):
remove a test that tested a wring behaviour

diff --git a/ChangeLog b/ChangeLog
index 225b40278f629f034a2af8e86117b68aff957043..6ac2b8eb69ad95d5c897b234ebd21030ce41bcde 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2004-12-16  Benjamin Otte  <in7y118@public.uni-hamburg.de>
+
+       * gst/gstvalue.c: (gst_value_deserialize_string):
+         check that a simple string that gets deserialized does not contain
+         invalid characters
+       * testsuite/caps/value_serialize.c: (test_string_deserialization):
+         remove a test that tested a wring behaviour
+
 2004-12-16  Matt Kraai  <kraai@alumni.cmu.edu>
 
        Reviewed by:  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

diff --git a/gst/gstvalue.c b/gst/gstvalue.c
index a11a3d8f1dbcb63d0f39eae8213fee1c8491293e..1f8549c0f87c1e7897661614ec8ba90851aa20c3 100644 (file)
--- a/gst/gstvalue.c
+++ b/gst/gstvalue.c
@@ -1332,6 +1332,12 @@ static gboolean
 gst_value_deserialize_string (GValue * dest, const char *s)
 {
   if (*s != '"') {
+    const gchar *t = s;
+
+    while (GST_ASCII_IS_STRING (*t))
+      t++;
+    if (!*t == '\0')
+      return FALSE;
     g_value_set_string (dest, s);
     return TRUE;
   } else {

diff --git a/tests/old/testsuite/caps/value_serialize.c b/tests/old/testsuite/caps/value_serialize.c
index ec67141d65886877d392611566ab0aa0f01a6794..b6980045ee8223e247c90562938f99300ee81af9 100644 (file)
--- a/tests/old/testsuite/caps/value_serialize.c
+++ b/tests/old/testsuite/caps/value_serialize.c
@@ -62,7 +62,6 @@ test_string_deserialization (void)
   } tests[] = {
     {
     "", ""}, {
-    "\\", "\\"}, {
     "\"\"", ""},
         /* FAILURES */
     {

diff --git a/testsuite/caps/value_serialize.c b/testsuite/caps/value_serialize.c
index ec67141d65886877d392611566ab0aa0f01a6794..b6980045ee8223e247c90562938f99300ee81af9 100644 (file)
--- a/testsuite/caps/value_serialize.c
+++ b/testsuite/caps/value_serialize.c
@@ -62,7 +62,6 @@ test_string_deserialization (void)
   } tests[] = {
     {
     "", ""}, {
-    "\\", "\\"}, {
     "\"\"", ""},
         /* FAILURES */
     {