pmdomain: arm: Use FLAG_DEV_NAME_FW to ensure unique names
authorSibi Sankar <quic_sibis@quicinc.com>
Wed, 30 Oct 2024 12:55:11 +0000 (18:25 +0530)
committerUlf Hansson <ulf.hansson@linaro.org>
Wed, 30 Oct 2024 16:11:56 +0000 (17:11 +0100)
The domain attributes returned by the perf protocol can end up reporting
identical names across domains, resulting in debugfs node creation failure.
Use the GENPD_FLAG_DEV_NAME_FW to ensure the genpd providers end up with an
unique name.

Logs: [X1E reports 'NCC' for all its scmi perf domains]
debugfs: Directory 'NCC' with parent 'pm_genpd' already present!
debugfs: Directory 'NCC' with parent 'pm_genpd' already present!

Reported-by: Johan Hovold <johan+linaro@kernel.org>
Closes: https://lore.kernel.org/lkml/ZoQjAWse2YxwyRJv@hovoldconsulting.com/
Suggested-by: Ulf Hansson <ulf.hansson@linaro.org>
Suggested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: Sibi Sankar <quic_sibis@quicinc.com>
Cc: stable@vger.kernel.org
Message-ID: <20241030125512.2884761-6-quic_sibis@quicinc.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/pmdomain/arm/scmi_perf_domain.c

index d7ef46ccd9b8a414f8066f7fe2718f9867c89003..3693423459c9cc74a0f4f4ae67643e095729f8eb 100644 (file)
@@ -125,7 +125,8 @@ static int scmi_perf_domain_probe(struct scmi_device *sdev)
                scmi_pd->ph = ph;
                scmi_pd->genpd.name = scmi_pd->info->name;
                scmi_pd->genpd.flags = GENPD_FLAG_ALWAYS_ON |
-                                      GENPD_FLAG_OPP_TABLE_FW;
+                                      GENPD_FLAG_OPP_TABLE_FW |
+                                      GENPD_FLAG_DEV_NAME_FW;
                scmi_pd->genpd.set_performance_state = scmi_pd_set_perf_state;
                scmi_pd->genpd.attach_dev = scmi_pd_attach_dev;
                scmi_pd->genpd.detach_dev = scmi_pd_detach_dev;