media: rcar-vin: Clean up correct notifier in error path
authorNiklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Tue, 2 Jul 2019 17:42:58 +0000 (13:42 -0400)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Thu, 25 Jul 2019 10:20:58 +0000 (06:20 -0400)
The parallel input initialization error path cleans up the wrong
async notifier, fix this by cleaning up the correct notifier.

Fixes: 9863bc8695bc36e3 ("media: rcar-vin: Cleanup notifier in error path")
Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Reviewed-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/platform/rcar-vin/rcar-core.c

index 64f9cf7..a6efe1a 100644 (file)
@@ -633,7 +633,7 @@ static int rvin_parallel_init(struct rvin_dev *vin)
        ret = v4l2_async_notifier_register(&vin->v4l2_dev, &vin->notifier);
        if (ret < 0) {
                vin_err(vin, "Notifier registration failed\n");
-               v4l2_async_notifier_cleanup(&vin->group->notifier);
+               v4l2_async_notifier_cleanup(&vin->notifier);
                return ret;
        }