added lcov comment to exclude functions does not be invoked 92/151492/1 accepted/tizen/unified/20170922.065140 submit/tizen/20170921.060854
authorIckhee Woo <ickhee.woo@samsung.com>
Thu, 21 Sep 2017 05:26:51 +0000 (14:26 +0900)
committerIckhee Woo <ickhee.woo@samsung.com>
Thu, 21 Sep 2017 05:26:51 +0000 (14:26 +0900)
Change-Id: If647cec9815779f2faf2fbabe8d5dbcbfe1f1a3b
Signed-off-by: Ickhee Woo <ickhee.woo@samsung.com>
packaging/sync-manager.spec
src/sync-service/SyncManager_RepositoryEngine.cpp

index 59c76809166aadd71babd845031969ef74ba1bac..79a426c9470451fe447a45f3bb92229eacdfaf7f 100644 (file)
@@ -2,7 +2,7 @@
 %global __provides_exclude_from ^.*\\.extension-calendar
 
 Name:      sync-service
-Version:   0.3.34
+Version:   0.3.35
 Release:   1
 License:   Apache-2.0
 Summary:   Sync manager daemon
index 1b7e6b772c055987ef2d4e01460c4263055b6d4b..980afa82a1790e143aa36c8dd955c3b682eec3e3 100644 (file)
@@ -152,16 +152,7 @@ RepositoryEngine::RepositoryEngine(void) {
 }
 
 
-//Test method
-/*
-static void
-bndl_iterator_test(const char* pKey, const char* pVal, void* pData)
-{
-       LOG_LOGD("SyncJobQueue sync extra key %s val %s", pKey, pVal);
-}
-*/
-
-
+/* LCOV_EXCL_START */
 void
 RepositoryEngine::CheckSyncJobsData(void) {
        LOG_LOGD("Verifying Sync jobs");
@@ -175,28 +166,22 @@ RepositoryEngine::CheckSyncJobsData(void) {
        doc = xmlParseFile(pDocName);
 
        if (doc == NULL) {
-               /* LCOV_EXCL_START */
                LOG_LOGD("Failed to parse syncjobs.xml");
                doc = xmlParseFile(pDocName);
-               /* LCOV_EXCL_STOP */
        }
 
        cur = xmlDocGetRootElement(doc);
        if (cur == NULL) {
-               /* LCOV_EXCL_START */
                LOG_LOGD("Found empty document while parsing syncjobs.xml");
                xmlFreeDoc(doc);
                return;
-               /* LCOV_EXCL_STOP */
        }
 
        /* Parse sync jobs */
        if (xmlStrcmp(cur->name, XML_NODE_JOBS)) {
-               /* LCOV_EXCL_START */
                LOG_LOGD("Found empty document while parsing syncjobs.xml");
                xmlFreeDoc(doc);
                return;
-               /* LCOV_EXCL_STOP */
        } else {
                xmlChar* pTotalJobsCount = xmlGetProp(cur, XML_ATTR_JOBS_COUNT);
                int totalcount = (pTotalJobsCount == NULL) ? 0 : atoi((char*)pTotalJobsCount);
@@ -210,6 +195,7 @@ RepositoryEngine::CheckSyncJobsData(void) {
                }
        }
 }
+/* LCOV_EXCL_STOP */
 
 
 bool
@@ -260,6 +246,7 @@ RepositoryEngine::CheckAdapterStatus(const char *PackageName) {
 }
 
 
+/* LCOV_EXCL_START */
 static void
 RemoveLegacySyncData(const char *pCommandLine) {
        char cmd[128];
@@ -272,8 +259,10 @@ RemoveLegacySyncData(const char *pCommandLine) {
        else
                LOG_LOGD("rm %s : failed", cmd);
 }
+/* LCOV_EXCL_STOP */
 
 
+/* LCOV_EXCL_START */
 void
 RepositoryEngine::ReadSyncJobsData(void) {
        LOG_LOGD("Reading Sync jobs");
@@ -287,28 +276,22 @@ RepositoryEngine::ReadSyncJobsData(void) {
        doc = xmlParseFile(pDocName);
 
        if (doc == NULL) {
-               /* LCOV_EXCL_START */
                LOG_LOGD("Failed to parse syncjobs.xml");
                doc = xmlParseFile(pDocName);
-               /* LCOV_EXCL_STOP */
        }
 
        cur = xmlDocGetRootElement(doc);
        if (cur == NULL) {
-               /* LCOV_EXCL_START */
                LOG_LOGD("Found empty document while parsing syncjobs.xml");
                xmlFreeDoc(doc);
                return;
-               /* LCOV_EXCL_STOP */
        }
 
        /* Parse sync jobs */
        if (xmlStrcmp(cur->name, XML_NODE_JOBS)) {
-               /* LCOV_EXCL_START */
                LOG_LOGD("Found empty document while parsing syncjobs.xml");
                xmlFreeDoc(doc);
                return;
-               /* LCOV_EXCL_STOP */
        } else {
                xmlChar* pTotalJobsCount = xmlGetProp(cur, XML_ATTR_JOBS_COUNT);
                int totalcount = (pTotalJobsCount == NULL) ? 0 : atoi((char*)pTotalJobsCount);
@@ -321,7 +304,6 @@ RepositoryEngine::ReadSyncJobsData(void) {
 
                cur = cur->xmlChildrenNode;
                while (cur != NULL) {
-                       /* LCOV_EXCL_START */
                        if (!xmlStrcmp(cur->name, XML_NODE_PACKAGE)) {
                                xmlChar* pPackageId;
                                xmlChar* pJobsCount;
@@ -344,7 +326,6 @@ RepositoryEngine::ReadSyncJobsData(void) {
                                }
                        }
                        cur = cur->next;
-                       /* LCOV_EXCL_STOP */
                }
        }
 
@@ -373,8 +354,10 @@ RepositoryEngine::ReadSyncJobsData(void) {
        RemoveLegacySyncData(PATH_SYNCJOBS);
        RemoveLegacySyncData(PATH_SYNCDIR);
 }
+/* LCOV_EXCL_STOP */
 
 
+/* LCOV_EXCL_START */
 void
 RepositoryEngine::ReadSyncAdapters(void) {
        LOG_LOGD("Reading sync adapters");
@@ -388,28 +371,22 @@ RepositoryEngine::ReadSyncAdapters(void) {
        doc = xmlParseFile(pDocName);
 
        if (doc == NULL) {
-               /* LCOV_EXCL_START */
                LOG_LOGD("Failed to parse syncadapters.xml");
                doc = xmlParseFile(pDocName);
-               /* LCOV_EXCL_STOP */
        }
 
        cur = xmlDocGetRootElement(doc);
        if (cur == NULL) {
-               /* LCOV_EXCL_START */
                LOG_LOGD("Found empty document while parsing syncadapters.xml");
                xmlFreeDoc(doc);
                return;
-               /* LCOV_EXCL_STOP */
        }
 
        /* Parse sync jobs */
        if (xmlStrcmp(cur->name, XML_NODE_SYNCADAPTERS)) {
-               /* LCOV_EXCL_START */
                LOG_LOGD("Found empty document while parsing syncadapters.xml");
                xmlFreeDoc(doc);
                return;
-               /* LCOV_EXCL_STOP */
        } else {
                xmlChar* pSACount;
                pSACount = xmlGetProp(cur, XML_ATTR_COUNT);
@@ -464,7 +441,7 @@ RepositoryEngine::ReadSyncAdapters(void) {
 
        int ret = xmlSaveFormatFileEnc(PATH_SYNCADAPTERS, doc, "UTF-8", 1);
        if (ret < 0)
-               LOG_LOGD("Failed to write sync adapter data, error [%d]", ret); /* LCOV_EXCL_LINE */
+               LOG_LOGD("Failed to write sync adapter data, error [%d]", ret);
 
        xmlFreeDoc(doc);
        xmlCleanupParser();
@@ -473,6 +450,7 @@ RepositoryEngine::ReadSyncAdapters(void) {
 
        RemoveLegacySyncData(PATH_SYNCADAPTERS);
 }
+/* LCOV_EXCL_STOP */
 
 
 /* LCOV_EXCL_START */
@@ -486,6 +464,7 @@ bndl_iterator(const char* pKey, const char* pVal, void* pData) {
 /* LCOV_EXCL_STOP */
 
 
+/* LCOV_EXCL_START */
 void
 RepositoryEngine::WriteSyncJobsData(void) {
        LOG_LOGD("Writing sync jobs");
@@ -509,7 +488,6 @@ RepositoryEngine::WriteSyncJobsData(void) {
 
        map<string, SyncJobsInfo*>::iterator itr = syncJobs.begin();
        while (itr != syncJobs.end()) {
-               /* LCOV_EXCL_START */
                string package = itr->first;
                SyncJobsInfo* pJobsInfo = itr->second;
 
@@ -574,20 +552,21 @@ RepositoryEngine::WriteSyncJobsData(void) {
                        }
                }
                itr++;
-               /* LCOV_EXCL_STOP */
        }
 
        int ret = xmlSaveFormatFileEnc(PATH_SYNCJOBS, doc, "UTF-8" , 1);
        if (ret < 0) {
-               LOG_LOGD("Failed to write account data, error [%d], errno [%d]", ret, errno);   /* LCOV_EXCL_LINE */
+               LOG_LOGD("Failed to write account data, error [%d], errno [%d]", ret, errno);
        }
        xmlFreeDoc(doc);
        xmlCleanupParser();
 
        LOG_LOGD("Ends");
 }
+/* LCOV_EXCL_STOP */
 
 
+/* LCOV_EXCL_START */
 void
 RepositoryEngine::WriteSyncAdapters(void) {
        LOG_LOGD("Writing sync adapters");
@@ -603,11 +582,9 @@ RepositoryEngine::WriteSyncAdapters(void) {
 
        SyncAdapterAggregator* pAggregator = SyncManager::GetInstance()->GetSyncAdapterAggregator();
        if (!pAggregator) {
-               /* LCOV_EXCL_START */
                LOG_LOGD("Failed to get sync adapter aggregator, skip writing to file");
                xmlFreeDoc(doc);
                return;
-               /* LCOV_EXCL_STOP */
        }
 
        ss << pAggregator->__syncAdapterList.size();
@@ -631,13 +608,14 @@ RepositoryEngine::WriteSyncAdapters(void) {
 
        int ret = xmlSaveFormatFileEnc(PATH_SYNCADAPTERS, doc, "UTF-8", 1);
        if (ret < 0) {
-               LOG_LOGD("Failed to write sync adapter data, error [%d]", ret); /* LCOV_EXCL_LINE */
+               LOG_LOGD("Failed to write sync adapter data, error [%d]", ret);
        }
        xmlFreeDoc(doc);
        xmlCleanupParser();
 
        LOG_LOGD("Ends");
 }
+/* LCOV_EXCL_STOP */
 
 
 /* LCOV_EXCL_START */
@@ -651,8 +629,10 @@ RepositoryEngine::ParseExtras(xmlNodePtr cur, bundle* pExtra) {
 
        bundle_add_str(pExtra, (const char*)pKey, (const char*)pVal);
 }
+/* LCOV_EXCL_STOP */
 
 
+/* LCOV_EXCL_START */
 void
 RepositoryEngine::ParseSyncJobsN(xmlNodePtr cur, xmlChar* pPackage) {
        xmlChar* pAppId = xmlGetProp(cur, XML_ATTR_JOB_APP_ID);
@@ -776,6 +756,7 @@ static void db_close(sqlite3 *db) {
 }
 
 
+/* LCOV_EXCL_START */
 static void create_db_schema(void) {
        sqlite3 *db;
        db = db_open();
@@ -806,8 +787,10 @@ static void create_db_schema(void) {
 
        db_close(db);
 }
+/* LCOV_EXCL_STOP */
 
 
+/* LCOV_EXCL_START */
 static void create_db_file(void) {
        sqlite3 *db;
        db = db_open();
@@ -848,6 +831,7 @@ static void create_db_file(void) {
 
        create_db_schema();
 }
+/* LCOV_EXCL_STOP */
 
 
 static int check_db_file(void) {
@@ -891,8 +875,10 @@ RepositoryEngine::WhetherApplication(const char *PkgName) {
        sqlite3 *db = NULL;
        db = db_open();
        if (!db) {
+               /* LCOV_EXCL_START */
                LOG_LOGD("DB open error : couldn't get information for DoA");
                return isApp;
+               /* LCOV_EXCL_STOP */
        }
 
        char *search_query = NULL;
@@ -901,12 +887,14 @@ RepositoryEngine::WhetherApplication(const char *PkgName) {
 
        int ret = sqlite3_prepare_v2(db, search_query, strlen(search_query), &stmt, NULL);
        if (ret != SQLITE_OK) {
+               /* LCOV_EXCL_START */
                LOG_LOGD("prepare : search query[%s] ret[%d] err_msg[%s]", search_query, ret, sqlite3_errmsg(db));
                sqlite3_finalize(stmt);
                sqlite3_free(search_query);
                db_close(db);
                LOG_LOGD("sync-manager DB close : couldn't get information for DoA");
                return isApp;
+               /* LCOV_EXCL_STOP */
        }
 
        ret = sqlite3_step(stmt);
@@ -975,6 +963,7 @@ RepositoryEngine::WhetherPrivilegeNeeded(guint pid, const gchar *pCommandLine) {
 }
 
 
+/* LCOV_EXCL_START */
 int
 RepositoryEngine::ReadSyncAdaptersFromDB(void) {
        sqlite3 *db = NULL;
@@ -1061,6 +1050,7 @@ RepositoryEngine::ReadSyncAdaptersFromDB(void) {
 
        return 1;
 }
+/* LCOV_EXCL_STOP */
 
 
 int
@@ -1155,6 +1145,7 @@ RepositoryEngine::InsertSyncAdapterToDB(const char *SvcAppId, const char *PkgNam
 }
 
 
+/* LCOV_EXCL_START */
 int
 RepositoryEngine::UpdateSyncAdapterToDB(const char *SvcAppId, int UserId, const char *AppStatus, int ProcId) {
        sqlite3 *db = NULL;
@@ -1214,8 +1205,10 @@ RepositoryEngine::UpdateSyncAdapterToDB(const char *SvcAppId, int UserId, const
 
        return 0;
 }
+/* LCOV_EXCL_STOP */
 
 
+/* LCOV_EXCL_START */
 int
 RepositoryEngine::UpdateSyncAdapterToDB(const char *SvcAppId, int UserId, const char *AppStatus) {
        sqlite3 *db = NULL;
@@ -1273,6 +1266,7 @@ RepositoryEngine::UpdateSyncAdapterToDB(const char *SvcAppId, int UserId, const
 
        return 0;
 }
+/* LCOV_EXCL_STOP */
 
 
 int
@@ -1522,8 +1516,10 @@ RepositoryEngine::CheckSyncJobsDataOnDB(void) {
        sqlite3 *db = NULL;
        db = db_open();
        if (!db) {
+               /* LCOV_EXCL_START */
                LOG_LOGD("DB open error");
                return;
+               /* LCOV_EXCL_STOP */
        }
        LOG_LOGD("sync-manager DB open");
 
@@ -1535,12 +1531,14 @@ RepositoryEngine::CheckSyncJobsDataOnDB(void) {
 
        ret = sqlite3_prepare_v2(db, search_query, strlen(search_query), &stmt, NULL);
        if (ret != SQLITE_OK) {
+               /* LCOV_EXCL_START */
                LOG_LOGD("prepare : search query[%s] ret[%d] err_msg[%s]", search_query, ret, sqlite3_errmsg(db));
                sqlite3_finalize(stmt);
                sqlite3_free(search_query);
                db_close(db);
                LOG_LOGD("sync-manager DB close");
                return;
+               /* LCOV_EXCL_STOP */
        }
 
        ret = sqlite3_step(stmt);
@@ -1578,12 +1576,14 @@ RepositoryEngine::ReadSyncJobsDataFromDB(void) {
 
        int ret = sqlite3_prepare_v2(db, search_query, strlen(search_query), &stmt, NULL);
        if (ret != SQLITE_OK) {
+               /* LCOV_EXCL_START */
                LOG_LOGD("prepare : search query[%s] ret[%d] err_msg[%s]", search_query, ret, sqlite3_errmsg(db));
                sqlite3_finalize(stmt);
                sqlite3_free(search_query);
                db_close(db);
                LOG_LOGD("sync-manager DB close");
                return 0;
+               /* LCOV_EXCL_STOP */
        }
 
        ret = sqlite3_step(stmt);
@@ -1798,6 +1798,7 @@ RepositoryEngine::InsertSyncJobToDB(const char *SvcAppId, const char *PkgName, i
 }
 
 
+/* LCOV_EXCL_START */
 int
 RepositoryEngine::UpdateAppStatusToDB(const char *SvcAppId, const char *PkgName, int UserId, const char *AppStatus) {
        sqlite3 *db = NULL;
@@ -1854,6 +1855,7 @@ RepositoryEngine::UpdateAppStatusToDB(const char *SvcAppId, const char *PkgName,
 
        return 0;
 }
+/* LCOV_EXCL_STOP */
 
 
 int
@@ -1899,16 +1901,19 @@ RepositoryEngine::UpdateSyncJobToDB(const char *SvcAppId, int UserId, const char
                int ret = SQLITE_OK;
                ret = sqlite3_prepare_v2(db, update_query, strlen(update_query), &stmt, NULL);
                if (ret != SQLITE_OK) {
+                       /* LCOV_EXCL_START */
                        LOG_LOGD("prepare : update query[%s] ret[%d] err_msg[%s]", update_query, ret, sqlite3_errmsg(db));
                        sqlite3_finalize(stmt);
                        sqlite3_free(update_query);
                        db_close(db);
                        LOG_LOGD("sync-manager DB close");
                        return -1;
+                       /* LCOV_EXCL_STOP */
                }
 
                ret = sqlite3_step(stmt);
                if (ret != SQLITE_OK && ret != SQLITE_DONE) {
+                       /* LCOV_EXCL_START */
                        LOG_LOGD("DB error [%d : %s] for [%s]", ret, sqlite3_errmsg(db), update_query);
                        sqlite3_reset(stmt);
                        sqlite3_finalize(stmt);
@@ -1916,6 +1921,7 @@ RepositoryEngine::UpdateSyncJobToDB(const char *SvcAppId, int UserId, const char
                        db_close(db);
                        LOG_LOGD("sync-manager DB close");
                        return -1;
+                       /* LCOV_EXCL_STOP */
                }
 
                LOG_LOGD("result : Update sync job to DB complete [%s]", update_query);
@@ -1956,22 +1962,26 @@ RepositoryEngine::DeleteSyncJobFromDB(const char *PkgName, int UserId, int JobId
        if (PkgName && strlen(PkgName) > 0) {
                delete_query = sqlite3_mprintf("DELETE FROM %Q WHERE PkgName=%Q AND UserId=%Q AND SyncJobId=%Q", SYNC_JOB_TABLE, PkgName, uid, jobId);
        } else {
+               /* LCOV_EXCL_START */
                LOG_LOGD("Delete sync job fail : invalid package-name");
                db_close(db);
                LOG_LOGD("sync-manager DB close");
                return -1;
+               /* LCOV_EXCL_STOP */
        }
 
        sqlite3_stmt *stmt = NULL;
 
        ret = sqlite3_prepare_v2(db, delete_query, strlen(delete_query), &stmt, NULL);
        if (ret != SQLITE_OK) {
+               /* LCOV_EXCL_START */
                LOG_LOGD("prepare : delete query[%s] ret[%d] err_msg[%s]", delete_query, ret, sqlite3_errmsg(db));
                sqlite3_finalize(stmt);
                sqlite3_free(delete_query);
                db_close(db);
                LOG_LOGD("sync-manager DB close");
                return -1;
+               /* LCOV_EXCL_STOP */
        }
 
        ret = sqlite3_step(stmt);
@@ -1992,6 +2002,7 @@ RepositoryEngine::DeleteSyncJobFromDB(const char *PkgName, int UserId, int JobId
 }
 
 
+/* LCOV_EXCL_START */
 int
 RepositoryEngine::DeleteAllSyncJobsFromDB(const char *PkgName, int UserId) {
        sqlite3 *db = NULL;
@@ -2045,6 +2056,8 @@ RepositoryEngine::DeleteAllSyncJobsFromDB(const char *PkgName, int UserId) {
 
        return 0;
 }
+/* LCOV_EXCL_STOP */
 
 
 //}//_SyncManager
+