staging: rtl8192e: Remove unnecessary u16 assignment cast
authorSolomon Tan <wjsota@gmail.com>
Sat, 23 Apr 2022 13:01:47 +0000 (21:01 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 26 Apr 2022 09:35:18 +0000 (11:35 +0200)
Remove the explicit casts in assignment statements for u16 variables.
Because these variables are declared as u16, there is implicit
conversion to u16 during the assignment, so an explicit cast is
unnecessary.

Signed-off-by: Solomon Tan <wjsota@gmail.com>
Link: https://lore.kernel.org/r/20220423130150.161903-5-wjsota@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c

index c5e44bb..cd8bbc3 100644 (file)
@@ -58,7 +58,7 @@ bool rtl92e_send_cmd_pkt(struct net_device *dev, u32 type, const void *data,
                        memset(pTxFwInfo, 0, sizeof(struct tx_fwinfo_8190pci));
                        memset(pTxFwInfo, 0x12, 8);
                } else {
-                       tcb_desc->txbuf_size = (u16)frag_length;
+                       tcb_desc->txbuf_size = frag_length;
                }
 
                seg_ptr = skb_put(skb, frag_length);
index b608540..feddb15 100644 (file)
@@ -1225,7 +1225,7 @@ void  rtl92e_fill_tx_desc(struct net_device *dev, struct tx_desc *pdesc,
        pdesc->LINIP = 0;
        pdesc->CmdInit = 1;
        pdesc->Offset = sizeof(struct tx_fwinfo_8190pci) + 8;
-       pdesc->PktSize = (u16)skb->len-sizeof(struct tx_fwinfo_8190pci);
+       pdesc->PktSize = skb->len - sizeof(struct tx_fwinfo_8190pci);
 
        pdesc->SecCAMID = 0;
        pdesc->RATid = cb_desc->RATRIndex;
@@ -1298,8 +1298,7 @@ void  rtl92e_fill_tx_cmd_desc(struct net_device *dev, struct tx_desc_cmd *entry,
 
                entry_tmp->CmdInit = DESC_PACKET_TYPE_NORMAL;
                entry_tmp->Offset = sizeof(struct tx_fwinfo_8190pci) + 8;
-               entry_tmp->PktSize = (u16)(cb_desc->pkt_size +
-                                     entry_tmp->Offset);
+               entry_tmp->PktSize = cb_desc->pkt_size + entry_tmp->Offset;
                entry_tmp->QueueSelect = QSLT_CMD;
                entry_tmp->TxFWInfoSize = 0x08;
                entry_tmp->RATid = DESC_PACKET_TYPE_INIT;