ASoC: sun8i-codec: Invert Master / Slave condition
authorMaxime Ripard <maxime.ripard@free-electrons.com>
Wed, 8 Nov 2017 15:47:08 +0000 (16:47 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 30 Nov 2017 08:40:49 +0000 (08:40 +0000)
commit 560bfe774f058e97596f30ff71cffdac52b72914 upstream.

The current code had the condition backward when checking if the codec
should be running in slave or master mode.

Fix it, and make the comment a bit more readable.

Fixes: 36c684936fae ("ASoC: Add sun8i digital audio codec")
Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Reviewed-by: Chen-Yu Tsai <wens@csie.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sound/soc/sunxi/sun8i-codec.c

index abfb710..038107b 100644 (file)
@@ -170,11 +170,11 @@ static int sun8i_set_fmt(struct snd_soc_dai *dai, unsigned int fmt)
 
        /* clock masters */
        switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) {
-       case SND_SOC_DAIFMT_CBS_CFS: /* DAI Slave */
-               value = 0x0; /* Codec Master */
+       case SND_SOC_DAIFMT_CBS_CFS: /* Codec slave, DAI master */
+               value = 0x1;
                break;
-       case SND_SOC_DAIFMT_CBM_CFM: /* DAI Master */
-               value = 0x1; /* Codec Slave */
+       case SND_SOC_DAIFMT_CBM_CFM: /* Codec Master, DAI slave */
+               value = 0x0;
                break;
        default:
                return -EINVAL;