tpm_tis: make array cmd_getticks static const to shrink object code size
authorColin Ian King <colin.king@canonical.com>
Fri, 25 Aug 2017 16:45:05 +0000 (17:45 +0100)
committerJarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Wed, 18 Oct 2017 15:28:23 +0000 (18:28 +0300)
Don't populate array cmd_getticks on the stack, instead make it static
const.  Makes the object code smaller by over 160 bytes:

Before:
   text    data     bss     dec     hex filename
  18813    3152     128   22093    564d drivers/char/tpm/tpm_tis_core.o

After:
   text    data     bss     dec     hex filename
  18554    3248     128   21930    55aa drivers/char/tpm/tpm_tis_core.o

Cc: stable@vger.kernel.org
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
drivers/char/tpm/tpm_tis_core.c

index 63bc6c3..1e957e9 100644 (file)
@@ -445,7 +445,7 @@ static int probe_itpm(struct tpm_chip *chip)
 {
        struct tpm_tis_data *priv = dev_get_drvdata(&chip->dev);
        int rc = 0;
-       u8 cmd_getticks[] = {
+       static const u8 cmd_getticks[] = {
                0x00, 0xc1, 0x00, 0x00, 0x00, 0x0a,
                0x00, 0x00, 0x00, 0xf1
        };