Fix static analysis issue

AUTO_CAUSES_COPY
COPY_INSTEAD_OF_MOVE

Change-Id: Ibbc278d580394d4331a1e93b6b7c9e8bd1ee8cc2
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>

diff --git a/src/hybrid/hybrid_installer.cc b/src/hybrid/hybrid_installer.cc
index 99acd08e26f85ce8b229b038e83da39458e185bc..081b90d5c2610a349cad99bbc19e18514abaf09c 100644 (file)
--- a/src/hybrid/hybrid_installer.cc
+++ b/src/hybrid/hybrid_installer.cc
@@ -47,7 +47,7 @@ namespace ci = common_installer;
 namespace hybrid {
 
 HybridInstaller::HybridInstaller(common_installer::PkgMgrPtr pkgmgr)
-    : AppInstaller("wgt", pkgmgr) {
+    : AppInstaller("wgt", std::move(pkgmgr)) {
   context_->cross_app_rules.set(true);
   context_->backend_data.set(new HybridBackendData());
 }

diff --git a/src/lib/wgt_archive_info.h b/src/lib/wgt_archive_info.h
index 776fd055a33602b8bb9fee1e78e9cda4b99fa691..bdfbf8fc13557f7f470a7005cd9007803f962f56 100644 (file)
--- a/src/lib/wgt_archive_info.h
+++ b/src/lib/wgt_archive_info.h
@@ -17,7 +17,7 @@ namespace fs = std::filesystem;
 class WgtArchiveInfo : public common_installer::ArchiveInfo {
  public:
   explicit WgtArchiveInfo(std::string path)
-      : common_installer::ArchiveInfo(path) { }
+      : common_installer::ArchiveInfo(std::move(path)) { }
   bool LoadArchiveInfo() override;
   bool ExtractPackageArchive(const std::string& archive_path,
       const std::string& file, const std::string& tmp_dir) override;

diff --git a/src/wgt/step/configuration/step_set_old_signature_files_location.cc b/src/wgt/step/configuration/step_set_old_signature_files_location.cc
index 402f68ca69f1b5658640dd168f8a8a3752828b7a..c89024aa3e40d875a44867e4ab9fca16d7104f30 100644 (file)
--- a/src/wgt/step/configuration/step_set_old_signature_files_location.cc
+++ b/src/wgt/step/configuration/step_set_old_signature_files_location.cc
@@ -25,9 +25,7 @@ ci::Step::Status StepSetOldSignatureFilesLocation::process() {
   // StepCheckSignature gets path of signature files from unpacked_dir from
   // unpacked_dir, which is root directory of package, but signature files
   // are not at root directory.
-  fs::path oldpath = context_->unpacked_dir_path.get();
-  fs::path newpath = oldpath / kWgtPath;
-  context_->unpacked_dir_path.set(newpath);
+  context_->unpacked_dir_path.set(context_->unpacked_dir_path.get() / kWgtPath);
   return Status::OK;
 }
 

diff --git a/src/wgt/step/filesystem/step_wgt_prepare_package_directory.cc b/src/wgt/step/filesystem/step_wgt_prepare_package_directory.cc
index 4e79dc2eef61c9f824ed39e19b93b28be38988d3..db392696a2af3d9e11177f513bc0258dbfe26515 100644 (file)
--- a/src/wgt/step/filesystem/step_wgt_prepare_package_directory.cc
+++ b/src/wgt/step/filesystem/step_wgt_prepare_package_directory.cc
@@ -73,9 +73,7 @@ ci::Step::Status StepWgtPreparePackageDirectory::CreateSymlinks() {
 }
 
 ci::Step::Status StepWgtPreparePackageDirectory::ExtractEntries() {
-  fs::path backup_path =
-      ci::GetBackupPathForPackagePath(context_->GetPkgPath());
-  backupPath_ = backup_path;
+  backupPath_ = ci::GetBackupPathForPackagePath(context_->GetPkgPath());
 
   fs::path resource_path = context_->GetPkgPath() / kResWgtDirectory;
   std::error_code error;

diff --git a/src/wgt/utils/extension_config_parser.cc b/src/wgt/utils/extension_config_parser.cc
index 7583c46613658e44b9c9cb5a52eacf70c404ed57..cd803dad8f0bdf9bdefddfe92d095fce1a3ffa71 100644 (file)
--- a/src/wgt/utils/extension_config_parser.cc
+++ b/src/wgt/utils/extension_config_parser.cc
@@ -26,7 +26,7 @@ const char kExtensionNameKey[] = "@name";
 }  // namespace
 
 ExtensionConfigParser::ExtensionConfigParser(std::string config_xml)
-    : config_xml_(config_xml) {}
+    : config_xml_(std::move(config_xml)) {}
 
 std::unique_ptr<parser::DictionaryValue>
     ExtensionConfigParser::LoadExtensionConfig(const std::string& config_xml) {

diff --git a/src/wgt/wgt_installer.cc b/src/wgt/wgt_installer.cc
index 24aa8761fa1c201b52bb934497d0d83205dcb328..b9d6a4e9bb3a325218fe0e5ca59a91913ee4d8eb 100644 (file)
--- a/src/wgt/wgt_installer.cc
+++ b/src/wgt/wgt_installer.cc
@@ -49,7 +49,7 @@ namespace ci = common_installer;
 namespace wgt {
 
 WgtInstaller::WgtInstaller(ci::PkgMgrPtr pkgrmgr)
-    : AppInstaller("wgt", pkgrmgr) {
+    : AppInstaller("wgt", std::move(pkgrmgr)) {
   context_->backend_data.set(new WgtBackendData());
 }
 

diff --git a/test/smoke_tests/manifest_test.cc b/test/smoke_tests/manifest_test.cc
index 0f7bdf4fde7dc6c556cea902146fa3f1e84ea75d..ea5232ae97f55ef893549cf7ac285871aad7e7a8 100644 (file)
--- a/test/smoke_tests/manifest_test.cc
+++ b/test/smoke_tests/manifest_test.cc
@@ -482,7 +482,7 @@ TEST_F(ManifestTest, SettingsElement_Valid) {
   manifest_x* m = runner.GetManifest();
   ASSERT_NE(m, nullptr);
   auto backend_data = runner.GetBackendData();
-  auto settings = backend_data->settings.get();
+  const auto& settings = backend_data->settings.get();
 
   ASSERT_EQ(settings.background_support_enabled(), true);
   ASSERT_EQ(settings.context_menu_enabled(), false);
@@ -501,7 +501,7 @@ TEST_F(ManifestTest, SettingsElement_BackgroundSupportEnabled) {
   manifest_x* m = runner.GetManifest();
   ASSERT_NE(m, nullptr);
   auto backend_data = runner.GetBackendData();
-  auto settings = backend_data->settings.get();
+  const auto& settings = backend_data->settings.get();
   ASSERT_EQ(settings.background_support_enabled(), true);
 }
 
@@ -511,7 +511,7 @@ TEST_F(ManifestTest, SettingsElement_BackgroundSupportDisabled) {
   manifest_x* m = runner.GetManifest();
   ASSERT_NE(m, nullptr);
   auto backend_data = runner.GetBackendData();
-  auto settings = backend_data->settings.get();
+  const auto& settings = backend_data->settings.get();
   ASSERT_EQ(settings.background_support_enabled(), false);
 }
 
@@ -521,7 +521,7 @@ TEST_F(ManifestTest, SettingsElement_MissingBackgroundSupport) {
   manifest_x* m = runner.GetManifest();
   ASSERT_NE(m, nullptr);
   auto backend_data = runner.GetBackendData();
-  auto settings = backend_data->settings.get();
+  const auto& settings = backend_data->settings.get();
   ASSERT_EQ(settings.background_support_enabled(), false);
 }
 
@@ -531,7 +531,7 @@ TEST_F(ManifestTest, SettingsElement_BackgroundVibrationEnabled) {
   manifest_x* m = runner.GetManifest();
   ASSERT_NE(m, nullptr);
   auto backend_data = runner.GetBackendData();
-  auto settings = backend_data->settings.get();
+  const auto& settings = backend_data->settings.get();
   ASSERT_EQ(settings.background_vibration(), true);
 }
 
@@ -541,7 +541,7 @@ TEST_F(ManifestTest, SettingsElement_BackgroundVibrationDisabled) {
   manifest_x* m = runner.GetManifest();
   ASSERT_NE(m, nullptr);
   auto backend_data = runner.GetBackendData();
-  auto settings = backend_data->settings.get();
+  const auto& settings = backend_data->settings.get();
   ASSERT_EQ(settings.background_vibration(), false);
 }
 
@@ -551,7 +551,7 @@ TEST_F(ManifestTest, SettingsElement_MissingBackgroundVibration) {
   manifest_x* m = runner.GetManifest();
   ASSERT_NE(m, nullptr);
   auto backend_data = runner.GetBackendData();
-  auto settings = backend_data->settings.get();
+  const auto& settings = backend_data->settings.get();
   ASSERT_EQ(settings.background_vibration(), false);
 }
 
@@ -561,7 +561,7 @@ TEST_F(ManifestTest, SettingsElement_ContextMenuEnabled) {
   manifest_x* m = runner.GetManifest();
   ASSERT_NE(m, nullptr);
   auto backend_data = runner.GetBackendData();
-  auto settings = backend_data->settings.get();
+  const auto& settings = backend_data->settings.get();
   ASSERT_EQ(settings.context_menu_enabled(), true);
 }
 
@@ -571,7 +571,7 @@ TEST_F(ManifestTest, SettingsElement_ContextMenuDisabled) {
   manifest_x* m = runner.GetManifest();
   ASSERT_NE(m, nullptr);
   auto backend_data = runner.GetBackendData();
-  auto settings = backend_data->settings.get();
+  const auto& settings = backend_data->settings.get();
   ASSERT_EQ(settings.context_menu_enabled(), false);
 }
 
@@ -581,7 +581,7 @@ TEST_F(ManifestTest, SettingsElement_MissingContextMenu) {
   manifest_x* m = runner.GetManifest();
   ASSERT_NE(m, nullptr);
   auto backend_data = runner.GetBackendData();
-  auto settings = backend_data->settings.get();
+  const auto& settings = backend_data->settings.get();
   ASSERT_EQ(settings.context_menu_enabled(), true);
 }
 
@@ -591,7 +591,7 @@ TEST_F(ManifestTest, SettingsElement_EncryptionEnabled) {
   manifest_x* m = runner.GetManifest();
   ASSERT_NE(m, nullptr);
   auto backend_data = runner.GetBackendData();
-  auto settings = backend_data->settings.get();
+  const auto& settings = backend_data->settings.get();
   ASSERT_EQ(settings.encryption_enabled(), true);
 }
 
@@ -601,7 +601,7 @@ TEST_F(ManifestTest, SettingsElement_EncryptionDisabled) {
   manifest_x* m = runner.GetManifest();
   ASSERT_NE(m, nullptr);
   auto backend_data = runner.GetBackendData();
-  auto settings = backend_data->settings.get();
+  const auto& settings = backend_data->settings.get();
   ASSERT_EQ(settings.encryption_enabled(), false);
 }
 
@@ -611,7 +611,7 @@ TEST_F(ManifestTest, SettingsElement_MissingEncryption) {
   manifest_x* m = runner.GetManifest();
   ASSERT_NE(m, nullptr);
   auto backend_data = runner.GetBackendData();
-  auto settings = backend_data->settings.get();
+  const auto& settings = backend_data->settings.get();
   ASSERT_EQ(settings.encryption_enabled(), false);
 }
 
@@ -621,7 +621,7 @@ TEST_F(ManifestTest, SettingsElement_HwKeyEnabled) {
   manifest_x* m = runner.GetManifest();
   ASSERT_NE(m, nullptr);
   auto backend_data = runner.GetBackendData();
-  auto settings = backend_data->settings.get();
+  const auto& settings = backend_data->settings.get();
   ASSERT_EQ(settings.hwkey_enabled(), true);
 }
 
@@ -631,7 +631,7 @@ TEST_F(ManifestTest, SettingsElement_HwKeyDisabled) {
   manifest_x* m = runner.GetManifest();
   ASSERT_NE(m, nullptr);
   auto backend_data = runner.GetBackendData();
-  auto settings = backend_data->settings.get();
+  const auto& settings = backend_data->settings.get();
   ASSERT_EQ(settings.hwkey_enabled(), false);
 }
 
@@ -641,7 +641,7 @@ TEST_F(ManifestTest, SettingsElement_MissingHwKeyEvent) {
   manifest_x* m = runner.GetManifest();
   ASSERT_NE(m, nullptr);
   auto backend_data = runner.GetBackendData();
-  auto settings = backend_data->settings.get();
+  const auto& settings = backend_data->settings.get();
   ASSERT_EQ(settings.hwkey_enabled(), true);
 }
 
@@ -651,7 +651,7 @@ TEST_F(ManifestTest, SettingsElement_MissingInstallLocation) {
   manifest_x* m = runner.GetManifest();
   ASSERT_NE(m, nullptr);
   auto backend_data = runner.GetBackendData();
-  auto settings = backend_data->settings.get();
+  const auto& settings = backend_data->settings.get();
   ASSERT_EQ(settings.install_location(),
             wgt::parse::SettingInfo::InstallLocation::AUTO);
 }
@@ -662,7 +662,7 @@ TEST_F(ManifestTest, SettingsElement_MissingScreenOrientation) {
   manifest_x* m = runner.GetManifest();
   ASSERT_NE(m, nullptr);
   auto backend_data = runner.GetBackendData();
-  auto settings = backend_data->settings.get();
+  const auto& settings = backend_data->settings.get();
   ASSERT_EQ(settings.screen_orientation(),
             wgt::parse::SettingInfo::ScreenOrientation::AUTO);
 }