soc: imx: imx93-pd: Fix the error handling path of imx93_pd_probe()
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sat, 22 Oct 2022 06:08:55 +0000 (08:08 +0200)
committerShawn Guo <shawnguo@kernel.org>
Sat, 29 Oct 2022 08:26:32 +0000 (16:26 +0800)
In imx93_pd_probe(); if an error occurs, some resources need to be released
as done in the remove function.

Fixes: 0a0f7cc25d4a ("soc: imx: add i.MX93 SRC power domain driver")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Shawn Guo <shawnguo@kernel.org>
drivers/soc/imx/imx93-pd.c

index 1f3d703..4d235c8 100644 (file)
@@ -135,11 +135,24 @@ static int imx93_pd_probe(struct platform_device *pdev)
 
        ret = pm_genpd_init(&domain->genpd, NULL, domain->init_off);
        if (ret)
-               return ret;
+               goto err_clk_unprepare;
 
        platform_set_drvdata(pdev, domain);
 
-       return of_genpd_add_provider_simple(np, &domain->genpd);
+       ret = of_genpd_add_provider_simple(np, &domain->genpd);
+       if (ret)
+               goto err_genpd_remove;
+
+       return 0;
+
+err_genpd_remove:
+       pm_genpd_remove(&domain->genpd);
+
+err_clk_unprepare:
+       if (!domain->init_off)
+               clk_bulk_disable_unprepare(domain->num_clks, domain->clks);
+
+       return ret;
 }
 
 static const struct of_device_id imx93_pd_ids[] = {