staging: rtl8188eu: make two arrays static const, makes object smaller
authorColin Ian King <colin.king@canonical.com>
Fri, 6 Sep 2019 17:39:49 +0000 (18:39 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 12 Sep 2019 09:35:52 +0000 (10:35 +0100)
Don't populate two arrays on the stack but instead make them
static const. Makes the object code smaller by 49 bytes.

Before:
   text    data     bss     dec     hex filename
  26821    5616       0   32437    7eb5 rtl8188eu/core/rtw_ieee80211.o

After:
   text    data     bss     dec     hex filename
  26612    5776       0   32388    7e84 rtl8188eu/core/rtw_ieee80211.o

(gcc version 9.2.1, amd64)

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Link: https://lore.kernel.org/r/20190906173949.21860-1-colin.king@canonical.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8188eu/core/rtw_ieee80211.c

index 28b3cdd..cc1b543 100644 (file)
@@ -59,7 +59,7 @@ static u8 WIFI_OFDMRATES[] = {
 
 int rtw_get_bit_value_from_ieee_value(u8 val)
 {
-       unsigned char dot11_rate_table[] = {
+       static const unsigned char dot11_rate_table[] = {
                2, 4, 11, 22, 12, 18, 24, 36, 48,
                72, 96, 108, 0}; /*  last element must be zero!! */
        int i = 0;
@@ -275,7 +275,7 @@ unsigned char *rtw_get_wpa_ie(unsigned char *pie, uint *wpa_ie_len, int limit)
        uint len;
        u16 val16;
        __le16 le_tmp;
-       unsigned char wpa_oui_type[] = {0x00, 0x50, 0xf2, 0x01};
+       static const unsigned char wpa_oui_type[] = {0x00, 0x50, 0xf2, 0x01};
        u8 *pbuf = pie;
        int limit_new = limit;