[perl #116587] Data::Dumper intermittently fails tests on 5.8.*

In a nutshell, we don't care enough about 5.8 to try really hard to fix
(obscure) vstring problems there. But we care enough not to make DD fail
its tests because of such a corner case. We don't want to screw all
users that are trapped in the last decade.

Thus, skip certain tests pre-5.10.

diff --git a/dist/Data-Dumper/t/dumper.t b/dist/Data-Dumper/t/dumper.t
index 6f618de..c1e5fe6 100644 (file)
--- a/dist/Data-Dumper/t/dumper.t
+++ b/dist/Data-Dumper/t/dumper.t
@@ -1510,9 +1510,16 @@ VSTRINGS_CORRECT
     \v65.66.6_7,
     \~v190.189.188
   );
-  TEST q(Data::Dumper->Dump(\@::_v, [qw(a b c d)])), 'vstrings';
-  TEST q(Data::Dumper->Dumpxs(\@::_v, [qw(a b c d)])), 'xs vstrings'
-    if $XS;
+  if ($] >= 5.010) {
+    TEST q(Data::Dumper->Dump(\@::_v, [qw(a b c d)])), 'vstrings';
+    TEST q(Data::Dumper->Dumpxs(\@::_v, [qw(a b c d)])), 'xs vstrings'
+      if $XS;
+  }
+  else { # Skip tests before 5.10. vstrings considered funny before
+    SKIP_TEST "vstrings considered funny before 5.10.0";
+    SKIP_TEST "vstrings considered funny before 5.10.0 (XS)"
+      if $XS;
+  }
 }
 
 ############# 384