projects
/
kernel
/
kernel-generic.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
0d7614f
)
xfs: fix uninitialised variable in xfs_rtbuf_get()
author
Dave Chinner
<dchinner@redhat.com>
Tue, 31 Jul 2012 04:55:51 +0000
(14:55 +1000)
committer
Ben Myers
<bpm@sgi.com>
Thu, 23 Aug 2012 19:48:16 +0000
(14:48 -0500)
Results in this assert failure in generic/090:
XFS: Assertion failed: *nmap >= 1, file: fs/xfs/xfs_bmap.c, line: 4363
.....
Call Trace:
[<
ffffffff814680db
>] xfs_bmapi_read+0x6b/0x370
[<
ffffffff814b64b2
>] xfs_rtbuf_get+0x42/0x130
[<
ffffffff814b6f09
>] xfs_rtget_summary+0x89/0x120
[<
ffffffff814b7bfe
>] xfs_rtallocate_extent_size+0xce/0x340
[<
ffffffff814b89f0
>] xfs_rtallocate_extent+0x240/0x290
[<
ffffffff81462c1a
>] xfs_bmap_rtalloc+0x1ba/0x340
[<
ffffffff81463a65
>] xfs_bmap_alloc+0x35/0x40
[<
ffffffff8146f111
>] xfs_bmapi_allocate+0xf1/0x350
[<
ffffffff8146f9de
>] xfs_bmapi_write+0x66e/0xa60
[<
ffffffff8144538a
>] xfs_iomap_write_direct+0x22a/0x3f0
[<
ffffffff8143707b
>] __xfs_get_blocks+0x38b/0x5d0
[<
ffffffff814372d4
>] xfs_get_blocks_direct+0x14/0x20
[<
ffffffff811b0081
>] do_blockdev_direct_IO+0xf71/0x1eb0
[<
ffffffff811b1015
>] __blockdev_direct_IO+0x55/0x60
[<
ffffffff814355ca
>] xfs_vm_direct_IO+0x11a/0x1e0
[<
ffffffff8112d617
>] generic_file_direct_write+0xd7/0x1b0
[<
ffffffff8143e16c
>] xfs_file_dio_aio_write+0x13c/0x320
[<
ffffffff8143e6f2
>] xfs_file_aio_write+0x1c2/0x1d0
[<
ffffffff81174a07
>] do_sync_write+0xa7/0xe0
[<
ffffffff81175288
>] vfs_write+0xa8/0x160
[<
ffffffff81175702
>] sys_pwrite64+0x92/0xb0
[<
ffffffff81b68f69
>] system_call_fastpath+0x16/0x1b
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Ben Myers <bpm@sgi.com>
fs/xfs/xfs_rtalloc.c
patch
|
blob
|
history
diff --git
a/fs/xfs/xfs_rtalloc.c
b/fs/xfs/xfs_rtalloc.c
index
92d4331
..
ca28a4b
100644
(file)
--- a/
fs/xfs/xfs_rtalloc.c
+++ b/
fs/xfs/xfs_rtalloc.c
@@
-857,7
+857,7
@@
xfs_rtbuf_get(
xfs_buf_t *bp; /* block buffer, result */
xfs_inode_t *ip; /* bitmap or summary inode */
xfs_bmbt_irec_t map;
- int nmap;
+ int nmap
= 1
;
int error; /* error value */
ip = issum ? mp->m_rsumip : mp->m_rbmip;