net: mvpp2: Improve two size determinations in mvpp2_probe()
authorMarkus Elfring <elfring@users.sourceforge.net>
Mon, 17 Apr 2017 06:38:32 +0000 (08:38 +0200)
committerDavid S. Miller <davem@davemloft.net>
Tue, 18 Apr 2017 17:55:07 +0000 (13:55 -0400)
Replace the specification of two data structures by pointer dereferences
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/marvell/mvpp2.c

index a86d911..04aba23 100644 (file)
@@ -6873,7 +6873,7 @@ static int mvpp2_probe(struct platform_device *pdev)
        int port_count, cpu;
        int err;
 
-       priv = devm_kzalloc(&pdev->dev, sizeof(struct mvpp2), GFP_KERNEL);
+       priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL);
        if (!priv)
                return -ENOMEM;
 
@@ -6970,8 +6970,8 @@ static int mvpp2_probe(struct platform_device *pdev)
        }
 
        priv->port_list = devm_kcalloc(&pdev->dev, port_count,
-                                     sizeof(struct mvpp2_port *),
-                                     GFP_KERNEL);
+                                      sizeof(*priv->port_list),
+                                      GFP_KERNEL);
        if (!priv->port_list) {
                err = -ENOMEM;
                goto err_mg_clk;