drm/radeon: check the alloc_workqueue return value in radeon_crtc_init()
authorYang Yingliang <yangyingliang@huawei.com>
Thu, 30 Nov 2023 07:50:16 +0000 (15:50 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 25 Jan 2024 23:35:34 +0000 (15:35 -0800)
[ Upstream commit 7a2464fac80d42f6f8819fed97a553e9c2f43310 ]

check the alloc_workqueue return value in radeon_crtc_init()
to avoid null-ptr-deref.

Fixes: fa7f517cb26e ("drm/radeon: rework page flip handling v4")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/radeon/radeon_display.c

index 901e75e..efd18c8 100644 (file)
@@ -687,11 +687,16 @@ static void radeon_crtc_init(struct drm_device *dev, int index)
        if (radeon_crtc == NULL)
                return;
 
+       radeon_crtc->flip_queue = alloc_workqueue("radeon-crtc", WQ_HIGHPRI, 0);
+       if (!radeon_crtc->flip_queue) {
+               kfree(radeon_crtc);
+               return;
+       }
+
        drm_crtc_init(dev, &radeon_crtc->base, &radeon_crtc_funcs);
 
        drm_mode_crtc_set_gamma_size(&radeon_crtc->base, 256);
        radeon_crtc->crtc_id = index;
-       radeon_crtc->flip_queue = alloc_workqueue("radeon-crtc", WQ_HIGHPRI, 0);
        rdev->mode_info.crtcs[index] = radeon_crtc;
 
        if (rdev->family >= CHIP_BONAIRE) {