mailbox: xgene-slimpro: Use device-managed registration API
authorThierry Reding <treding@nvidia.com>
Thu, 20 Dec 2018 17:19:54 +0000 (18:19 +0100)
committerJassi Brar <jaswinder.singh@linaro.org>
Fri, 21 Dec 2018 22:49:25 +0000 (16:49 -0600)
Get rid of some boilerplate driver removal code by using the newly added
device-managed registration API.

Signed-off-by: Thierry Reding <treding@nvidia.com>
Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
drivers/mailbox/mailbox-xgene-slimpro.c

index b8b2b35..8f397da 100644 (file)
@@ -224,7 +224,7 @@ static int slimpro_mbox_probe(struct platform_device *pdev)
        ctx->mb_ctrl.ops = &slimpro_mbox_ops;
        ctx->mb_ctrl.num_chans = i;
 
-       rc = mbox_controller_register(&ctx->mb_ctrl);
+       rc = devm_mbox_controller_register(&pdev->dev, &ctx->mb_ctrl);
        if (rc) {
                dev_err(&pdev->dev,
                        "APM X-Gene SLIMpro MailBox register failed:%d\n", rc);
@@ -235,14 +235,6 @@ static int slimpro_mbox_probe(struct platform_device *pdev)
        return 0;
 }
 
-static int slimpro_mbox_remove(struct platform_device *pdev)
-{
-       struct slimpro_mbox *smb = platform_get_drvdata(pdev);
-
-       mbox_controller_unregister(&smb->mb_ctrl);
-       return 0;
-}
-
 static const struct of_device_id slimpro_of_match[] = {
        {.compatible = "apm,xgene-slimpro-mbox" },
        { },
@@ -259,7 +251,6 @@ MODULE_DEVICE_TABLE(acpi, slimpro_acpi_ids);
 
 static struct platform_driver slimpro_mbox_driver = {
        .probe  = slimpro_mbox_probe,
-       .remove = slimpro_mbox_remove,
        .driver = {
                .name = "xgene-slimpro-mbox",
                .of_match_table = of_match_ptr(slimpro_of_match),