Fix Svace issue - "new_handle" is compared to NULL after dereferenced

[Version] 0.2.48
[Profile] Common
[Issue Type] Svace
[Dependency module] N/A
[Dependency commit] N/A
[Test] [M(T) - Boot=(OK), sdb=(OK), Home=(OK), Touch=(OK), Version=tizen-mobile_20160906.1]

Change-Id: I88afa599f817715067f15a609529f43fe6063644
Signed-off-by: Jeongmo Yang <jm80.yang@samsung.com>

diff --git a/legacy/src/legacy_camera.c b/legacy/src/legacy_camera.c
index d0e356a..cd05235 100644 (file)
--- a/legacy/src/legacy_camera.c
+++ b/legacy/src/legacy_camera.c
@@ -725,10 +725,8 @@ int legacy_camera_change_device(camera_h *camera, camera_device_e device)
        return CAMERA_ERROR_NONE;
 
 _CHANGE_DEVICE_FAILED:
-       if (new_handle) {
-               legacy_camera_destroy((camera_h)new_handle);
-               new_handle = NULL;
-       }
+       legacy_camera_destroy((camera_h)new_handle);
+       new_handle = NULL;
 
        if (reuse_element) {
                mm_camcorder_set_attributes(old_handle->mm_handle, NULL,

diff --git a/packaging/mmsvc-camera.spec b/packaging/mmsvc-camera.spec
index 049df3b..2c0faa3 100644 (file)
--- a/packaging/mmsvc-camera.spec
+++ b/packaging/mmsvc-camera.spec
@@ -1,6 +1,6 @@
 Name:       mmsvc-camera
 Summary:    A Camera module for muse server
-Version:    0.2.47
+Version:    0.2.48
 Release:    0
 Group:      Multimedia/Libraries
 License:    Apache-2.0