Input: bcm-keypad - correct dev_err_probe() error
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Wed, 12 Jul 2023 18:53:23 +0000 (11:53 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Wed, 12 Jul 2023 18:54:19 +0000 (11:54 -0700)
Pass proper PTR_ERR as dev_err_probe() argument.

Fixes: a2c795b696b2 ("Input: bcm-keypad - simplify with dev_err_probe()")
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/r/202306261505.wTjCXRIO-lkp@intel.com/
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20230711072449.43569-1-krzysztof.kozlowski@linaro.org
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/keyboard/bcm-keypad.c

index 0aa6ef0..f3c3746 100644 (file)
@@ -359,7 +359,7 @@ static int bcm_kp_probe(struct platform_device *pdev)
        /* Enable clock */
        kp->clk = devm_clk_get_optional(&pdev->dev, "peri_clk");
        if (IS_ERR(kp->clk)) {
-               return dev_err_probe(&pdev->dev, error, "Failed to get clock\n");
+               return dev_err_probe(&pdev->dev, PTR_ERR(kp->clk), "Failed to get clock\n");
        } else if (!kp->clk) {
                dev_dbg(&pdev->dev, "No clock specified. Assuming it's enabled\n");
        } else {