soundwire: stream: use sdw_write instead of update
authorSrinivas Kandagatla <srinivas.kandagatla@linaro.org>
Thu, 12 Mar 2020 10:01:05 +0000 (10:01 +0000)
committerVinod Koul <vkoul@kernel.org>
Fri, 13 Mar 2020 12:36:05 +0000 (18:06 +0530)
There is no point in using update for registers with write mask
as 0xFF, this adds unnecessary traffic on the bus.
Just use sdw_write directly.

Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20200312100105.5293-1-srinivas.kandagatla@linaro.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/soundwire/stream.c

index 00348d1..1b43d03 100644 (file)
@@ -313,9 +313,9 @@ static int sdw_enable_disable_slave_ports(struct sdw_bus *bus,
         * it is safe to reset this register
         */
        if (en)
-               ret = sdw_update(s_rt->slave, addr, 0xFF, p_rt->ch_mask);
+               ret = sdw_write(s_rt->slave, addr, p_rt->ch_mask);
        else
-               ret = sdw_update(s_rt->slave, addr, 0xFF, 0x0);
+               ret = sdw_write(s_rt->slave, addr, 0x0);
 
        if (ret < 0)
                dev_err(&s_rt->slave->dev,
@@ -464,10 +464,9 @@ static int sdw_prep_deprep_slave_ports(struct sdw_bus *bus,
                addr = SDW_DPN_PREPARECTRL(p_rt->num);
 
                if (prep)
-                       ret = sdw_update(s_rt->slave, addr,
-                                        0xFF, p_rt->ch_mask);
+                       ret = sdw_write(s_rt->slave, addr, p_rt->ch_mask);
                else
-                       ret = sdw_update(s_rt->slave, addr, 0xFF, 0x0);
+                       ret = sdw_write(s_rt->slave, addr, 0x0);
 
                if (ret < 0) {
                        dev_err(&s_rt->slave->dev,