scsi: qla2xxx: Replace fcport alloc with qla2x00_alloc_fcport
authorQuinn Tran <quinn.tran@cavium.com>
Mon, 4 Dec 2017 22:45:10 +0000 (14:45 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 15 Mar 2018 09:54:26 +0000 (10:54 +0100)
commit 063b36d6b0ad74c748d536f5cb47bac2f850a0fa upstream.

Current code manually allocate an fcport structure that is not properly
initialize. Replace kzalloc with qla2x00_alloc_fcport, so that all
fields are initialized.  Also set set scan flag to port found

Cc: <stable@vger.kernel.org>
Signed-off-by: Quinn Tran <quinn.tran@cavium.com>
Signed-off-by: Himanshu Madhani <himanshu.madhani@cavium.com>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/scsi/qla2xxx/qla_target.c

index 7a7c4fe..995e461 100644 (file)
@@ -5759,7 +5759,7 @@ static fc_port_t *qlt_get_port_database(struct scsi_qla_host *vha,
        unsigned long flags;
        u8 newfcport = 0;
 
-       fcport = kzalloc(sizeof(*fcport), GFP_KERNEL);
+       fcport = qla2x00_alloc_fcport(vha, GFP_KERNEL);
        if (!fcport) {
                ql_dbg(ql_dbg_tgt_mgt, vha, 0xf06f,
                    "qla_target(%d): Allocation of tmp FC port failed",