staging: comedi: ni_mio_common: convert NI_GPCT_SUBDEV to a macro
authorH Hartley Sweeten <hsweeten@visionengravers.com>
Thu, 14 Apr 2016 16:57:59 +0000 (09:57 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 29 Apr 2016 05:17:28 +0000 (22:17 -0700)
The 'counter_index' is always in range (0 to < NUM_GPCT, which is 2).

For aesthetics, convert this inline function into a macro and remove
the BUG() which can never occur.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/ni_mio_common.c

index c56a518..8c2c4f6 100644 (file)
@@ -214,19 +214,7 @@ enum ni_common_subdevices {
        NI_NUM_SUBDEVICES
 };
 
-static inline unsigned int NI_GPCT_SUBDEV(unsigned int counter_index)
-{
-       switch (counter_index) {
-       case 0:
-               return NI_GPCT0_SUBDEV;
-       case 1:
-               return NI_GPCT1_SUBDEV;
-       default:
-               break;
-       }
-       BUG();
-       return NI_GPCT0_SUBDEV;
-}
+#define NI_GPCT_SUBDEV(x)      (NI_GPCT0_SUBDEV + (x))
 
 enum timebase_nanoseconds {
        TIMEBASE_1_NS = 50,