staging: vchiq_arm: Rework second abort criterion
authorStefan Wahren <stefan.wahren@i2se.com>
Sat, 28 Apr 2018 15:47:43 +0000 (17:47 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 7 May 2018 02:04:43 +0000 (19:04 -0700)
In order to make the code easier to review, move the second
abort criterion into the loop and the incrementation into
a separate line.

Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c

index d46a5b8..01fcd15 100644 (file)
@@ -3455,7 +3455,7 @@ vchiq_dump_service_use_state(VCHIQ_STATE_T *state)
        if (active_services > MAX_SERVICES)
                only_nonzero = 1;
 
-       for (i = 0; (i < active_services) && (j < MAX_SERVICES); i++) {
+       for (i = 0; i < active_services; i++) {
                VCHIQ_SERVICE_T *service_ptr = state->services[i];
 
                if (!service_ptr)
@@ -3469,7 +3469,10 @@ vchiq_dump_service_use_state(VCHIQ_STATE_T *state)
 
                service_data[j].fourcc = service_ptr->base.fourcc;
                service_data[j].clientid = service_ptr->client_id;
-               service_data[j++].use_count = service_ptr->service_use_count;
+               service_data[j].use_count = service_ptr->service_use_count;
+               j++;
+               if (j >= MAX_SERVICES)
+                       break;
        }
 
        read_unlock_bh(&arm_state->susp_res_lock);