drm: lots of small cleanups and whitespace issues fixed up
authorDave Airlie <airlied@linux.ie>
Sat, 19 Aug 2006 07:59:18 +0000 (17:59 +1000)
committerDave Airlie <airlied@linux.ie>
Sat, 19 Aug 2006 07:59:18 +0000 (17:59 +1000)
remove a mach64 warning, align a lot of things from linux kernel

24 files changed:
linux-core/drmP.h
linux-core/drm_bufs.c
linux-core/drm_fops.c
linux-core/drm_ioctl.c
linux-core/drm_irq.c
linux-core/drm_lock.c
linux-core/drm_pci.c
linux-core/drm_proc.c
linux-core/drm_sman.c
linux-core/drm_stub.c
linux-core/drm_vm.c
linux-core/i810_drv.h
linux-core/sis_drv.c
linux-core/via_dmablit.c
linux-core/via_dmablit.h
shared-core/mach64_drm.h
shared-core/radeon_drv.h
shared-core/radeon_state.c
shared-core/sis_drv.h
shared-core/via_dma.c
shared-core/via_drm.h
shared-core/via_drv.h
shared-core/via_irq.c
shared-core/via_verifier.h

index 642ab4b..6046dde 100644 (file)
@@ -298,8 +298,8 @@ typedef struct drm_devstate {
 } drm_devstate_t;
 
 typedef struct drm_magic_entry {
-        drm_hash_item_t hash_item;
-        struct list_head head;
+       drm_hash_item_t hash_item;
+       struct list_head head;
        struct drm_file *priv;
 } drm_magic_entry_t;
 
@@ -506,7 +506,7 @@ typedef struct drm_sigdata {
  */
 typedef struct drm_map_list {
        struct list_head head;          /**< list head */
-        drm_hash_item_t hash;
+       drm_hash_item_t hash;
        drm_map_t *map;                 /**< mapping */
        unsigned int user_token;
 } drm_map_list_t;
@@ -676,15 +676,15 @@ typedef struct drm_device {
        /*@{ */
        drm_file_t *file_first;         /**< file list head */
        drm_file_t *file_last;          /**< file list tail */
-        drm_open_hash_t magiclist;
-        struct list_head magicfree;
+       drm_open_hash_t magiclist;
+       struct list_head magicfree;
        /*@} */
 
        /** \name Memory management */
        /*@{ */
        drm_map_list_t *maplist;        /**< Linked list of regions */
        int map_count;                  /**< Number of mappable regions */
-        drm_open_hash_t map_hash;       /**< User token hash table for maps */
+       drm_open_hash_t map_hash;       /**< User token hash table for maps */
 
        /** \name Context handle management */
        /*@{ */
index eaec611..7d3121d 100644 (file)
@@ -290,13 +290,13 @@ static int drm_addmap_core(drm_device_t * dev, unsigned int offset,
 
        user_token = (map->type == _DRM_SHM) ? (unsigned long) map->handle : 
                map->offset;
-        ret = drm_map_handle(dev, &list->hash, user_token, 0); 
+       ret = drm_map_handle(dev, &list->hash, user_token, 0); 
 
        if (ret) {
-                drm_free(map, sizeof(*map), DRM_MEM_MAPS);
-                drm_free(list, sizeof(*list), DRM_MEM_MAPS);
-                mutex_unlock(&dev->struct_mutex);
-                return ret;
+               drm_free(map, sizeof(*map), DRM_MEM_MAPS);
+               drm_free(list, sizeof(*list), DRM_MEM_MAPS);
+               mutex_unlock(&dev->struct_mutex);
+               return ret;
        }
 
        list->user_token = list->hash.key;
@@ -384,7 +384,7 @@ int drm_rmmap_locked(drm_device_t *dev, drm_local_map_t *map)
 
                if (r_list->map == map) {
                        list_del(list);
-                        drm_ht_remove_key(&dev->map_hash, r_list->user_token);
+                       drm_ht_remove_key(&dev->map_hash, r_list->user_token);
                        drm_free(list, sizeof(*list), DRM_MEM_MAPS);
                        break;
                }
index 377007c..48c7754 100644 (file)
@@ -74,8 +74,8 @@ static int drm_setup(drm_device_t * dev)
        for (i = 0; i < ARRAY_SIZE(dev->counts); i++)
                atomic_set(&dev->counts[i], 0);
 
-        drm_ht_create(&dev->magiclist, DRM_MAGIC_HASH_ORDER);
-        INIT_LIST_HEAD(&dev->magicfree);
+       drm_ht_create(&dev->magiclist, DRM_MAGIC_HASH_ORDER);
+       INIT_LIST_HEAD(&dev->magicfree);
 
        dev->ctxlist = drm_alloc(sizeof(*dev->ctxlist), DRM_MEM_CTXLIST);
        if (dev->ctxlist == NULL)
index 2ea6af0..776f462 100644 (file)
@@ -242,7 +242,7 @@ int drm_getclient(struct inode *inode, struct file *filp,
 {
        drm_file_t *priv = filp->private_data;
        drm_device_t *dev = priv->head->dev;
-       drm_client_t __user *argp = (void __user *)arg;
+       drm_client_t __user *argp = (drm_client_t __user *)arg;
        drm_client_t client;
        drm_file_t *pt;
        int idx;
@@ -329,21 +329,23 @@ int drm_setversion(DRM_IOCTL_ARGS)
        int if_version;
        drm_set_version_t __user *argp = (void __user *)data;
  
-       DRM_COPY_FROM_USER_IOCTL(sv, argp, sizeof(sv));
+       if (copy_from_user(&sv, argp, sizeof(sv)))
+               return -EFAULT;
 
        retv.drm_di_major = DRM_IF_MAJOR;
        retv.drm_di_minor = DRM_IF_MINOR;
        retv.drm_dd_major = dev->driver->major;
        retv.drm_dd_minor = dev->driver->minor;
 
-       DRM_COPY_TO_USER_IOCTL(argp, retv, sizeof(sv));
+       if (copy_to_user(argp, &retv, sizeof(sv)))
+               return -EFAULT;
 
        if (sv.drm_di_major != -1) {
                if (sv.drm_di_major != DRM_IF_MAJOR ||
                    sv.drm_di_minor < 0 || sv.drm_di_minor > DRM_IF_MINOR)
                        return EINVAL;
                if_version = DRM_IF_VERSION(sv.drm_di_major, sv.drm_di_minor);
-               dev->if_version = DRM_MAX(if_version, dev->if_version);
+               dev->if_version = max(if_version, dev->if_version);
                if (sv.drm_di_minor >= 1) {
                        /*
                         * Version 1.1 includes tying of DRM to specific device
index 21a649b..c2a9e3d 100644 (file)
@@ -222,12 +222,12 @@ int drm_control(struct inode *inode, struct file *filp,
  * Wait for VBLANK.
  *
  * \param inode device inode.
- * \param filp file pointer.rm.
+ * \param filp file pointer.
  * \param cmd command.
  * \param data user argument, pointing to a drm_wait_vblank structure.
  * \return zero on success or a negative number on failure.
  *
- * Verifies the IRQ is installed
+ * Verifies the IRQ is installed.
  *
  * If a signal is requested checks if this task has already scheduled the same signal
  * for the same vblank sequence number - nothing to be done in
@@ -253,7 +253,8 @@ int drm_wait_vblank(DRM_IOCTL_ARGS)
        if ((!dev->irq) || (!dev->irq_enabled))
                return -EINVAL;
 
-       DRM_COPY_FROM_USER_IOCTL(vblwait, argp, sizeof(vblwait));
+       if (copy_from_user(&vblwait, argp, sizeof(vblwait)))
+               return -EFAULT;
 
        switch (vblwait.request.type & ~_DRM_VBLANK_FLAGS_MASK) {
        case _DRM_VBLANK_RELATIVE:
@@ -327,7 +328,8 @@ int drm_wait_vblank(DRM_IOCTL_ARGS)
        }
 
       done:
-       DRM_COPY_TO_USER_IOCTL(argp, vblwait, sizeof(vblwait));
+       if (copy_to_user(argp, &vblwait, sizeof(vblwait)))
+               return -EFAULT;
 
        return ret;
 }
index a268d8e..7aa00bc 100644 (file)
@@ -104,7 +104,7 @@ int drm_lock(struct inode *inode, struct file *filp,
        __set_current_state(TASK_RUNNING);
        remove_wait_queue(&dev->lock.lock_queue, &entry);
 
-        DRM_DEBUG( "%d %s\n", lock.context, ret ? "interrupted" : "has lock" );
+       DRM_DEBUG( "%d %s\n", lock.context, ret ? "interrupted" : "has lock" );
        if (ret) return ret;
 
        sigemptyset(&dev->sigmask);
index b69dda2..40a65f3 100644 (file)
@@ -37,6 +37,7 @@
  */
 
 #include <linux/pci.h>
+#include <linux/dma-mapping.h>
 #include "drmP.h"
 
 /**********************************************************************/
@@ -83,11 +84,7 @@ drm_dma_handle_t *drm_pci_alloc(drm_device_t * dev, size_t size, size_t align,
                return NULL;
 
        dmah->size = size;
-#if 0
-       dmah->vaddr = pci_alloc_consistent(dev->pdev, size, &dmah->busaddr);
-#else
        dmah->vaddr = dma_alloc_coherent(&dev->pdev->dev, size, &dmah->busaddr, GFP_KERNEL | __GFP_COMP);
-#endif
 
 #ifdef DRM_DEBUG_MEMORY
        if (dmah->vaddr == NULL) {
@@ -112,14 +109,12 @@ drm_dma_handle_t *drm_pci_alloc(drm_device_t * dev, size_t size, size_t align,
 
        memset(dmah->vaddr, 0, size);
 
-#if 1
        /* XXX - Is virt_to_page() legal for consistent mem? */
        /* Reserve */
        for (addr = (unsigned long)dmah->vaddr, sz = size;
             sz > 0; addr += PAGE_SIZE, sz -= PAGE_SIZE) {
                SetPageReserved(virt_to_page(addr));
        }
-#endif
 
        return dmah;
 }
@@ -132,10 +127,8 @@ EXPORT_SYMBOL(drm_pci_alloc);
  */
 void __drm_pci_free(drm_device_t * dev, drm_dma_handle_t *dmah)
 {
-#if 1
        unsigned long addr;
        size_t sz;
-#endif
 #ifdef DRM_DEBUG_MEMORY
        int area = DRM_MEM_DMA;
        int alloc_count;
@@ -147,21 +140,14 @@ void __drm_pci_free(drm_device_t * dev, drm_dma_handle_t *dmah)
                DRM_MEM_ERROR(area, "Attempt to free address 0\n");
 #endif
        } else {
-#if 1
                /* XXX - Is virt_to_page() legal for consistent mem? */
                /* Unreserve */
                for (addr = (unsigned long)dmah->vaddr, sz = dmah->size;
                     sz > 0; addr += PAGE_SIZE, sz -= PAGE_SIZE) {
                        ClearPageReserved(virt_to_page(addr));
                }
-#endif
-#if 0
-               pci_free_consistent(dev->pdev, dmah->size, dmah->vaddr,
-                                   dmah->busaddr);
-#else
                dma_free_coherent(&dev->pdev->dev, dmah->size, dmah->vaddr,
                                  dmah->busaddr);
-#endif
        }
 
 #ifdef DRM_DEBUG_MEMORY
@@ -181,7 +167,7 @@ void __drm_pci_free(drm_device_t * dev, drm_dma_handle_t *dmah)
 }
 
 /**
- * \brief Free a PCI consistent memory block.
+ * \brief Free a PCI consistent memory block
  */
 void drm_pci_free(drm_device_t * dev, drm_dma_handle_t *dmah)
 {
index 014486c..512a8f7 100644 (file)
@@ -258,7 +258,7 @@ static int drm__vm_info(char *buf, char **start, off_t offset, int request,
 }
 
 /**
- * Simply calls _vm_info() while holding the drm_device::struct_sem lock.
+ * Simply calls _vm_info() while holding the drm_device::struct_mutex lock.
  */
 static int drm_vm_info(char *buf, char **start, off_t offset, int request,
                       int *eof, void *data)
@@ -331,7 +331,7 @@ static int drm__queues_info(char *buf, char **start, off_t offset,
 }
 
 /**
- * Simply calls _queues_info() while holding the drm_device::struct_sem lock.
+ * Simply calls _queues_info() while holding the drm_device::struct_mutex lock.
  */
 static int drm_queues_info(char *buf, char **start, off_t offset, int request,
                           int *eof, void *data)
@@ -403,7 +403,7 @@ static int drm__bufs_info(char *buf, char **start, off_t offset, int request,
 }
 
 /**
- * Simply calls _bufs_info() while holding the drm_device::struct_sem lock.
+ * Simply calls _bufs_info() while holding the drm_device::struct_mutex lock.
  */
 static int drm_bufs_info(char *buf, char **start, off_t offset, int request,
                         int *eof, void *data)
@@ -459,7 +459,7 @@ static int drm__clients_info(char *buf, char **start, off_t offset,
 }
 
 /**
- * Simply calls _clients_info() while holding the drm_device::struct_sem lock.
+ * Simply calls _clients_info() while holding the drm_device::struct_mutex lock.
  */
 static int drm_clients_info(char *buf, char **start, off_t offset,
                            int request, int *eof, void *data)
index b92f0ee..425c823 100644 (file)
@@ -114,7 +114,7 @@ static void drm_sman_mm_destroy(void *private)
        drm_free(mm, sizeof(*mm), DRM_MEM_MM);
 }
 
-unsigned long drm_sman_mm_offset(void *private, void *ref)
+static unsigned long drm_sman_mm_offset(void *private, void *ref)
 {
        drm_mm_node_t *node = (drm_mm_node_t *) ref;
        return node->start;
index e4d61dc..bdc3655 100644 (file)
@@ -76,10 +76,10 @@ static int drm_fill_in_dev(drm_device_t * dev, struct pci_dev *pdev,
        if (dev->maplist == NULL)
                return -ENOMEM;
        INIT_LIST_HEAD(&dev->maplist->head);
-        if (drm_ht_create(&dev->map_hash, 12)) {
-                drm_free(dev->maplist, sizeof(*dev->maplist), DRM_MEM_MAPS);
-                return -ENOMEM;
-        }
+       if (drm_ht_create(&dev->map_hash, 12)) {
+               drm_free(dev->maplist, sizeof(*dev->maplist), DRM_MEM_MAPS);
+               return -ENOMEM;
+       }
 
        /* the DRM has 6 counters */
        dev->counters = 6;
index cf3bc3c..0391395 100644 (file)
@@ -59,7 +59,7 @@ static __inline__ struct page *drm_do_vm_nopage(struct vm_area_struct *vma,
        drm_device_t *dev = priv->head->dev;
        drm_map_t *map = NULL;
        drm_map_list_t *r_list;
-        drm_hash_item_t *hash;
+       drm_hash_item_t *hash;
 
        /*
         * Find the right map
@@ -70,10 +70,10 @@ static __inline__ struct page *drm_do_vm_nopage(struct vm_area_struct *vma,
        if (!dev->agp || !dev->agp->cant_use_aperture)
                goto vm_nopage_error;
 
-        if (drm_ht_find_item(&dev->map_hash, VM_OFFSET(vma), &hash)) 
-                goto vm_nopage_error;
+       if (drm_ht_find_item(&dev->map_hash, VM_OFFSET(vma), &hash)) 
+               goto vm_nopage_error;
 
-        r_list = drm_hash_entry(hash, drm_map_list_t, hash);
+       r_list = drm_hash_entry(hash, drm_map_list_t, hash);
        map = r_list->map;
 
        if (map && map->type == _DRM_AGP) {
@@ -554,7 +554,7 @@ int drm_mmap(struct file *filp, struct vm_area_struct *vma)
        drm_device_t *dev = priv->head->dev;
        drm_map_t *map = NULL;
        unsigned long offset = 0;
-        drm_hash_item_t *hash;
+       drm_hash_item_t *hash;
 
        DRM_DEBUG("start = 0x%lx, end = 0x%lx, offset = 0x%lx\n",
                  vma->vm_start, vma->vm_end, VM_OFFSET(vma));
@@ -574,11 +574,11 @@ int drm_mmap(struct file *filp, struct vm_area_struct *vma)
            )
                return drm_mmap_dma(filp, vma);
 
-        if (drm_ht_find_item(&dev->map_hash, VM_OFFSET(vma), &hash)) {
-                DRM_ERROR("Could not find map\n");
+       if (drm_ht_find_item(&dev->map_hash, VM_OFFSET(vma), &hash)) {
+               DRM_ERROR("Could not find map\n");
                return -EINVAL;
-        }
-        
+       }
+
        map = drm_hash_entry(hash,drm_map_list_t, hash)->map;
 
        if (!map || ((map->flags & _DRM_RESTRICTED) && !capable(CAP_SYS_ADMIN)))
index e8cf3ff..bb7358d 100644 (file)
@@ -141,8 +141,8 @@ extern int i810_max_ioctl;
                         volatile char *virt;
 
 #define BEGIN_LP_RING(n) do {                                          \
-       if (I810_VERBOSE)                                               \
-           DRM_DEBUG("BEGIN_LP_RING(%d) in %s\n", n, __FUNCTION__);    \
+       if (I810_VERBOSE)                                               \
+               DRM_DEBUG("BEGIN_LP_RING(%d) in %s\n", n, __FUNCTION__);\
        if (dev_priv->ring.space < n*4)                                 \
                i810_wait_ring(dev, n*4);                               \
        dev_priv->ring.space -= n*4;                                    \
@@ -151,17 +151,17 @@ extern int i810_max_ioctl;
        virt = dev_priv->ring.virtual_start;                            \
 } while (0)
 
-#define ADVANCE_LP_RING() do {                                 \
+#define ADVANCE_LP_RING() do {                                 \
        if (I810_VERBOSE) DRM_DEBUG("ADVANCE_LP_RING\n");       \
-       dev_priv->ring.tail = outring;                          \
-       I810_WRITE(LP_RING + RING_TAIL, outring);               \
+       dev_priv->ring.tail = outring;                          \
+       I810_WRITE(LP_RING + RING_TAIL, outring);               \
 } while(0)
 
-#define OUT_RING(n) do {                                               \
+#define OUT_RING(n) do {                                               \
        if (I810_VERBOSE) DRM_DEBUG("   OUT_RING %x\n", (int)(n));      \
-       *(volatile unsigned int *)(virt + outring) = n;                 \
-       outring += 4;                                                   \
-       outring &= ringmask;                                            \
+       *(volatile unsigned int *)(virt + outring) = n;                 \
+       outring += 4;                                                   \
+       outring &= ringmask;                                            \
 } while (0)
 
 #define GFX_OP_USER_INTERRUPT          ((0<<29)|(2<<23))
@@ -193,7 +193,7 @@ extern int i810_max_ioctl;
 #define HEAD_WRAP_ONE          0x00200000
 #define HEAD_ADDR              0x001FFFFC
 #define RING_START                     0x08
-#define START_ADDR             0x00FFFFF8
+#define START_ADDR             0x00FFFFF8
 #define RING_LEN                       0x0C
 #define RING_NR_PAGES          0x000FF000
 #define RING_REPORT_MASK       0x00000006
index 3fdbd88..36a525d 100644 (file)
@@ -40,15 +40,15 @@ static struct pci_device_id pciidlist[] = {
 static int sis_driver_load(drm_device_t *dev, unsigned long chipset)
 {
        drm_sis_private_t *dev_priv;
-        int ret;
+       int ret;
 
        dev_priv = drm_calloc(1, sizeof(drm_sis_private_t), DRM_MEM_DRIVER);
        if (dev_priv == NULL)
                return DRM_ERR(ENOMEM);
 
        dev->dev_private = (void *)dev_priv;
-        dev_priv->chipset = chipset;
-        ret = drm_sman_init(&dev_priv->sman, 2, 12, 8);
+       dev_priv->chipset = chipset;
+       ret = drm_sman_init(&dev_priv->sman, 2, 12, 8);
        if (ret) {
                drm_free(dev_priv, sizeof(dev_priv), DRM_MEM_DRIVER);
        }
@@ -60,7 +60,7 @@ static int sis_driver_unload(drm_device_t *dev)
 {
        drm_sis_private_t *dev_priv = dev->dev_private;
 
-        drm_sman_takedown(&dev_priv->sman);
+       drm_sman_takedown(&dev_priv->sman);
        drm_free(dev_priv, sizeof(*dev_priv), DRM_MEM_DRIVER);
 
        return 0;
@@ -70,10 +70,10 @@ static int sis_driver_unload(drm_device_t *dev)
 static int probe(struct pci_dev *pdev, const struct pci_device_id *ent);
 static struct drm_driver driver = {
        .driver_features = DRIVER_USE_AGP | DRIVER_USE_MTRR,
-        .load = sis_driver_load,
-        .unload = sis_driver_unload,
+       .load = sis_driver_load,
+       .unload = sis_driver_unload,
        .context_dtor = NULL,
-        .dma_quiescent = sis_idle,
+       .dma_quiescent = sis_idle,
        .reclaim_buffers = NULL,
        .reclaim_buffers_locked = sis_reclaim_buffers_locked,
        .lastclose = sis_lastclose,
index 4a3a752..61e6a10 100644 (file)
@@ -121,19 +121,18 @@ via_map_blit_for_device(struct pci_dev *pdev,
                
                while (line_len > 0) {
 
-                        remaining_len = min(PAGE_SIZE-VIA_PGOFF(cur_mem), line_len);
+                       remaining_len = min(PAGE_SIZE-VIA_PGOFF(cur_mem), line_len);
                        line_len -= remaining_len;
 
                        if (mode == 1) {
-                                desc_ptr->mem_addr = 
-                                       dma_map_page(&pdev->dev, 
-                                                    vsg->pages[VIA_PFN(cur_mem) - 
-                                                               VIA_PFN(first_addr)],
-                                                    VIA_PGOFF(cur_mem), remaining_len, 
-                                                    vsg->direction);
-                                desc_ptr->dev_addr = cur_fb;
+                               desc_ptr->mem_addr = dma_map_page(&pdev->dev, 
+                                       vsg->pages[VIA_PFN(cur_mem) - 
+                                       VIA_PFN(first_addr)],
+                                       VIA_PGOFF(cur_mem), remaining_len, 
+                                       vsg->direction);
+                               desc_ptr->dev_addr = cur_fb;
                                
-                                desc_ptr->size = remaining_len;
+                               desc_ptr->size = remaining_len;
                                desc_ptr->next = (uint32_t) next;
                                next = dma_map_single(&pdev->dev, desc_ptr, sizeof(*desc_ptr), 
                                                      DMA_TO_DEVICE);
@@ -167,7 +166,7 @@ via_map_blit_for_device(struct pci_dev *pdev,
  */
 
 
-void
+static void
 via_free_sg_info(struct pci_dev *pdev, drm_via_sg_info_t *vsg) 
 {
        struct page *page;
@@ -648,13 +647,13 @@ via_build_sg_info(drm_device_t *dev, drm_via_sg_info_t *vsg, drm_via_dmablit_t *
        if ((((unsigned long)xfer->mem_addr & 3) != ((unsigned long)xfer->fb_addr & 3)) ||
            ((xfer->num_lines > 1) && ((xfer->mem_stride & 3) != (xfer->fb_stride & 3)))) {
                DRM_ERROR("Invalid DRM bitblt alignment.\n");
-               return DRM_ERR(EINVAL);
+               return DRM_ERR(EINVAL);
        }
 #else
        if ((((unsigned long)xfer->mem_addr & 15) || ((unsigned long)xfer->fb_addr & 3)) ||
            ((xfer->num_lines > 1) && ((xfer->mem_stride & 15) || (xfer->fb_stride & 3)))) {
                DRM_ERROR("Invalid DRM bitblt alignment.\n");
-               return DRM_ERR(EINVAL);
+               return DRM_ERR(EINVAL);
        }       
 #endif
 
@@ -732,7 +731,7 @@ via_dmablit(drm_device_t *dev, drm_via_dmablit_t *xfer)
        drm_via_private_t *dev_priv = (drm_via_private_t *)dev->dev_private;
        drm_via_sg_info_t *vsg;
        drm_via_blitq_t *blitq;
-        int ret;
+       int ret;
        int engine;
        unsigned long irqsave;
 
index 6486391..f6ae03e 100644 (file)
@@ -30,6 +30,8 @@
 #ifndef _VIA_DMABLIT_H
 #define _VIA_DMABLIT_H
 
+#include <linux/dma-mapping.h>
+
 #define VIA_NUM_BLIT_ENGINES 2
 #define VIA_NUM_BLIT_SLOTS 8
 
@@ -43,12 +45,12 @@ typedef struct _drm_via_sg_info {
        int num_desc;
        enum dma_data_direction direction;
        unsigned char *bounce_buffer;
-        dma_addr_t chain_start;
+       dma_addr_t chain_start;
        uint32_t free_on_sequence;
-        unsigned int descriptors_per_page;
+       unsigned int descriptors_per_page;
        int aborted;
        enum {
-               dr_via_device_mapped,
+               dr_via_device_mapped,
                dr_via_desc_pages_alloc,
                dr_via_pages_locked,
                dr_via_pages_alloc,
@@ -66,7 +68,7 @@ typedef struct _drm_via_blitq {
        unsigned num_free;
        unsigned num_outstanding;
        unsigned long end;  
-        int aborting;
+       int aborting;
        int is_active;
        drm_via_sg_info_t *blits[VIA_NUM_BLIT_SLOTS];
        spinlock_t blit_lock;
index d92ece2..1fd8c00 100644 (file)
@@ -68,7 +68,7 @@
 /* Max number of swaps allowed on the ring
  * before the client must wait
  */
-#define MACH64_MAX_QUEUED_FRAMES        3
+#define MACH64_MAX_QUEUED_FRAMES        3U
 
 /* Byte offsets for host blit buffer data
  */
index ff75480..5fa8254 100644 (file)
@@ -1095,7 +1095,7 @@ do {                                                                      \
                           n, __FUNCTION__ );                           \
        }                                                               \
        if ( dev_priv->ring.space <= (n) * sizeof(u32) ) {              \
-                COMMIT_RING();                                         \
+               COMMIT_RING();                                          \
                radeon_wait_ring( dev_priv, (n) * sizeof(u32) );        \
        }                                                               \
        _nr = n; dev_priv->ring.space -= (n) * sizeof(u32);             \
index 58251dd..99672fa 100644 (file)
@@ -2653,10 +2653,10 @@ static __inline__ int radeon_emit_veclinear(drm_radeon_private_t *dev_priv,
        int start = header.veclinear.addr_lo | (header.veclinear.addr_hi << 8);
        RING_LOCALS;
 
-        if (!sz)
-                return 0;
-        if (sz * 4 > cmdbuf->bufsz)
-                return DRM_ERR(EINVAL);
+       if (!sz)
+               return 0;
+       if (sz * 4 > cmdbuf->bufsz)
+               return DRM_ERR(EINVAL);
 
        BEGIN_RING(5 + sz);
        OUT_RING_REG(RADEON_SE_TCL_STATE_FLUSH, 0);
index b739a48..d1cdc19 100644 (file)
@@ -40,8 +40,8 @@
 #define DRIVER_PATCHLEVEL      1
 
 enum sis_family {
-        SIS_OTHER = 0,
-        SIS_CHIP_315 = 1,
+       SIS_OTHER = 0,
+       SIS_CHIP_315 = 1,
 };
 
 #if defined(__linux__)
@@ -52,18 +52,18 @@ enum sis_family {
 #include "drm_sman.h"
 
 #define SIS_BASE (dev_priv->mmio)
-#define SIS_READ(reg)         DRM_READ32(SIS_BASE, reg);
+#define SIS_READ(reg)   DRM_READ32(SIS_BASE, reg);
 #define SIS_WRITE(reg, val)   DRM_WRITE32(SIS_BASE, reg, val);
 
 typedef struct drm_sis_private {
-        drm_local_map_t *mmio;
-        unsigned idle_fault;
-        drm_sman_t sman;
-        unsigned long chipset;
-        int vram_initialized;
-        int agp_initialized;
-        unsigned long vram_offset;
-        unsigned long agp_offset;
+       drm_local_map_t *mmio;
+       unsigned idle_fault;
+       drm_sman_t sman;
+       unsigned long chipset;
+       int vram_initialized;
+       int agp_initialized;
+       unsigned long vram_offset;
+       unsigned long agp_offset;
 } drm_sis_private_t;
 
 extern int sis_idle(drm_device_t *dev);
index 11fa738..c6e7aa7 100644 (file)
 #define CMDBUF_ALIGNMENT_MASK   (0x0ff)
 
 /* defines for VIA 3D registers */
-#define VIA_REG_STATUS          0x400
-#define VIA_REG_TRANSET         0x43C
+#define VIA_REG_STATUS   0x400
+#define VIA_REG_TRANSET         0x43C
 #define VIA_REG_TRANSPACE       0x440
 
 /* VIA_REG_STATUS(0x400): Engine Status */
 #define VIA_CMD_RGTR_BUSY       0x00000080     /* Command Regulator is busy */
-#define VIA_2D_ENG_BUSY         0x00000001     /* 2D Engine is busy */
-#define VIA_3D_ENG_BUSY         0x00000002     /* 3D Engine is busy */
+#define VIA_2D_ENG_BUSY         0x00000001     /* 2D Engine is busy */
+#define VIA_3D_ENG_BUSY         0x00000002     /* 3D Engine is busy */
 #define VIA_VR_QUEUE_BUSY       0x00020000     /* Virtual Queue is busy */
 
 #define SetReg2DAGP(nReg, nData) {                             \
@@ -120,7 +120,7 @@ via_cmdbuf_wait(drm_via_private_t * dev_priv, unsigned int size)
        next_addr = cur_addr + size + 512*1024;
        count = 1000000;
        do {
-               hw_addr = *hw_addr_ptr - agp_base;
+               hw_addr = *hw_addr_ptr - agp_base;
                if (count-- == 0) {
                        DRM_ERROR
                            ("via_cmdbuf_wait timed out hw %x cur_addr %x next_addr %x\n",
@@ -247,10 +247,10 @@ static int via_dma_init(DRM_IOCTL_ARGS)
                else
                        retcode = via_dma_cleanup(dev);
                break;
-        case VIA_DMA_INITIALIZED:
+       case VIA_DMA_INITIALIZED:
                retcode = (dev_priv->ring.virtual_start != NULL) ? 
                        0: DRM_ERR( EFAULT );
-               break;
+               break;
        default:
                retcode = DRM_ERR(EINVAL);
                break;
@@ -406,7 +406,7 @@ static int via_pci_cmdbuffer(DRM_IOCTL_ARGS)
 static inline uint32_t *via_align_buffer(drm_via_private_t * dev_priv,
                                         uint32_t * vb, int qw_count)
 {
-        for (; qw_count > 0; --qw_count) {
+       for (; qw_count > 0; --qw_count) {
                VIA_OUT_RING_QW(HC_DUMMY, HC_DUMMY);
        }
        return vb;
@@ -471,7 +471,7 @@ static int via_hook_segment(drm_via_private_t *dev_priv,
        }
                
        if (paused && !no_pci_fire) {
-               uint32_t rgtr,ptr;
+               uint32_t rgtr,ptr;
                uint32_t ptr_low;
 
                count = 1000000;
index 049c63e..60fb92c 100644 (file)
 #define VIA_DRM_DRIVER_MAJOR           2
 #define VIA_DRM_DRIVER_MINOR           10
 #define VIA_DRM_DRIVER_PATCHLEVEL      2
-#define VIA_DRM_DRIVER_VERSION          (((VIA_DRM_DRIVER_MAJOR) << 16) | (VIA_DRM_DRIVER_MINOR))
+#define VIA_DRM_DRIVER_VERSION   (((VIA_DRM_DRIVER_MAJOR) << 16) | (VIA_DRM_DRIVER_MINOR))
 
 #define VIA_NR_SAREA_CLIPRECTS                 8
-#define VIA_NR_XVMC_PORTS               10
-#define VIA_NR_XVMC_LOCKS               5
-#define VIA_MAX_CACHELINE_SIZE          64
+#define VIA_NR_XVMC_PORTS             10
+#define VIA_NR_XVMC_LOCKS             5
+#define VIA_MAX_CACHELINE_SIZE   64
 #define XVMCLOCKPTR(saPriv,lockNo)                                     \
        ((volatile drm_hw_lock_t *)(((((unsigned long) (saPriv)->XvMCLockArea) + \
                                      (VIA_MAX_CACHELINE_SIZE - 1)) &   \
 
 #define VIA_UPLOAD_TEX0IMAGE  0x1      /* handled clientside */
 #define VIA_UPLOAD_TEX1IMAGE  0x2      /* handled clientside */
-#define VIA_UPLOAD_CTX        0x4
+#define VIA_UPLOAD_CTX 0x4
 #define VIA_UPLOAD_BUFFERS    0x8
 #define VIA_UPLOAD_TEX0       0x10
 #define VIA_UPLOAD_TEX1       0x20
 #define VIA_UPLOAD_CLIPRECTS  0x40
-#define VIA_UPLOAD_ALL        0xff
+#define VIA_UPLOAD_ALL 0xff
 
 /* VIA specific ioctls */
 #define DRM_VIA_ALLOCMEM       0x00
-#define DRM_VIA_FREEMEM                0x01
+#define DRM_VIA_FREEMEM                0x01
 #define DRM_VIA_AGP_INIT       0x02
-#define DRM_VIA_FB_INIT                0x03
+#define DRM_VIA_FB_INIT                0x03
 #define DRM_VIA_MAP_INIT       0x04
 #define DRM_VIA_DEC_FUTEX       0x05
 #define NOT_USED
 #define DRM_VIA_DMA_INIT       0x07
 #define DRM_VIA_CMDBUFFER      0x08
-#define DRM_VIA_FLUSH          0x09
-#define DRM_VIA_PCICMD         0x0a
+#define DRM_VIA_FLUSH          0x09
+#define DRM_VIA_PCICMD         0x0a
 #define DRM_VIA_CMDBUF_SIZE    0x0b
 #define NOT_USED
-#define DRM_VIA_WAIT_IRQ        0x0d
-#define DRM_VIA_DMA_BLIT        0x0e
+#define DRM_VIA_WAIT_IRQ       0x0d
+#define DRM_VIA_DMA_BLIT       0x0e
 #define DRM_VIA_BLIT_SYNC       0x0f
 
 #define DRM_IOCTL_VIA_ALLOCMEM   DRM_IOWR(DRM_COMMAND_BASE + DRM_VIA_ALLOCMEM, drm_via_mem_t)
@@ -172,7 +172,7 @@ typedef struct _drm_via_dma_init {
        enum {
                VIA_INIT_DMA = 0x01,
                VIA_CLEANUP_DMA = 0x02,
-                VIA_DMA_INITIALIZED = 0x03
+               VIA_DMA_INITIALIZED = 0x03
        } func;
 
        unsigned long offset;
@@ -217,7 +217,7 @@ typedef struct _drm_via_sarea {
 
        /* Used by the 3d driver only at this point, for pageflipping:
         */
-        unsigned int pfCurrentOffset;
+       unsigned int pfCurrentOffset;
 } drm_via_sarea_t;
 
 typedef struct _drm_via_cmdbuf_size {
@@ -273,17 +273,17 @@ typedef struct drm_via_blitsync {
  */
 
 typedef struct drm_via_dmablit {
-       uint32_t num_lines;          
-       uint32_t line_length;        
+       uint32_t num_lines;       
+       uint32_t line_length;   
 
-        uint32_t fb_addr;                
-       uint32_t fb_stride;              
+       uint32_t fb_addr;               
+       uint32_t fb_stride;           
 
-        unsigned char *mem_addr;        
-       uint32_t  mem_stride;        
+       unsigned char *mem_addr;        
+       uint32_t  mem_stride;   
        
        uint32_t  flags;
-        int to_fb;
+       int to_fb;
 
        drm_via_blitsync_t sync;   
 } drm_via_dmablit_t;
index 86cd049..18d2a33 100644 (file)
@@ -76,9 +76,9 @@ typedef struct drm_via_private {
        volatile uint32_t *last_pause_ptr;
        volatile uint32_t *hw_addr_ptr;
        drm_via_ring_buffer_t ring;
-        struct timeval last_vblank;
-        int last_vblank_valid;
-        unsigned usec_per_vblank;
+       struct timeval last_vblank;
+       int last_vblank_valid;
+       unsigned usec_per_vblank;
        drm_via_state_t hc_state;
        char pci_buf[VIA_PCI_BUF_SIZE];
        const uint32_t *fire_offsets[VIA_FIRE_BUF_SIZE];
@@ -90,14 +90,14 @@ typedef struct drm_via_private {
        uint32_t irq_enable_mask; 
        uint32_t irq_pending_mask;      
        int *irq_map;
-        /* Memory manager stuff */
+       /* Memory manager stuff */
 #ifdef VIA_HAVE_CORE_MM
-       unsigned idle_fault;
+       unsigned int idle_fault;
        drm_sman_t sman;
        int vram_initialized;
        int agp_initialized;
-        unsigned long vram_offset;
-        unsigned long agp_offset;
+       unsigned long vram_offset;
+       unsigned long agp_offset;
 #endif
 #ifdef VIA_HAVE_DMABLIT
        drm_via_blitq_t blit_queues[VIA_NUM_BLIT_ENGINES];
@@ -148,8 +148,6 @@ extern int via_driver_dma_quiescent(drm_device_t * dev);
 extern void via_init_futex(drm_via_private_t *dev_priv);
 extern void via_cleanup_futex(drm_via_private_t *dev_priv);
 extern void via_release_futex(drm_via_private_t *dev_priv, int context);
-extern int via_driver_irq_wait(drm_device_t * dev, unsigned int irq,
-                              int force_sequence, unsigned int *sequence);
 
 #ifdef VIA_HAVE_CORE_MM
 extern void via_reclaim_buffers_locked(drm_device_t *dev, struct file *filp);
index aaba0cb..1862fbc 100644 (file)
@@ -43,7 +43,7 @@
 #define VIA_REG_INTERRUPT       0x200
 
 /* VIA_REG_INTERRUPT */
-#define VIA_IRQ_GLOBAL          (1 << 31)
+#define VIA_IRQ_GLOBAL   (1 << 31)
 #define VIA_IRQ_VBLANK_ENABLE   (1 << 19)
 #define VIA_IRQ_VBLANK_PENDING  (1 << 3)
 #define VIA_IRQ_HQV0_ENABLE     (1 << 11)
@@ -93,8 +93,8 @@ static int via_irqmap_unichrome[] = {-1, -1, -1, 0, -1, 1};
 static unsigned time_diff(struct timeval *now,struct timeval *then) 
 {
     return (now->tv_usec >= then->tv_usec) ?
-        now->tv_usec - then->tv_usec :
-        1000000 - (then->tv_usec - now->tv_usec);
+       now->tv_usec - then->tv_usec :
+       1000000 - (then->tv_usec - now->tv_usec);
 }
 
 irqreturn_t via_driver_irq_handler(DRM_IRQ_ARGS)
@@ -110,21 +110,21 @@ irqreturn_t via_driver_irq_handler(DRM_IRQ_ARGS)
        status = VIA_READ(VIA_REG_INTERRUPT);
        if (status & VIA_IRQ_VBLANK_PENDING) {
                atomic_inc(&dev->vbl_received);
-                if (!(atomic_read(&dev->vbl_received) & 0x0F)) {
+               if (!(atomic_read(&dev->vbl_received) & 0x0F)) {
 #ifdef __linux__
                        do_gettimeofday(&cur_vblank);
 #else
                        microtime(&cur_vblank);
 #endif
-                        if (dev_priv->last_vblank_valid) {
+                       if (dev_priv->last_vblank_valid) {
                                dev_priv->usec_per_vblank = 
                                        time_diff(&cur_vblank,
                                                  &dev_priv->last_vblank) >> 4;
                        }
                        dev_priv->last_vblank = cur_vblank;
                        dev_priv->last_vblank_valid = 1;
-                }
-                if (!(atomic_read(&dev->vbl_received) & 0xFF)) {
+               }
+               if (!(atomic_read(&dev->vbl_received) & 0xFF)) {
                        DRM_DEBUG("US per vblank is: %u\n",
                                dev_priv->usec_per_vblank);
                }
@@ -198,13 +198,13 @@ int via_driver_vblank_wait(drm_device_t * dev, unsigned int *sequence)
        return ret;
 }
 
-int 
+static int 
 via_driver_irq_wait(drm_device_t * dev, unsigned int irq, int force_sequence,
                    unsigned int *sequence)
 {
        drm_via_private_t *dev_priv = (drm_via_private_t *) dev->dev_private;
        unsigned int cur_irq_sequence;
-       drm_via_irq_t *cur_irq = dev_priv->via_irqs;
+       drm_via_irq_t *cur_irq;
        int ret = 0;
        maskarray_t *masks;
        int real_irq;
@@ -231,7 +231,7 @@ via_driver_irq_wait(drm_device_t * dev, unsigned int irq, int force_sequence,
        }
 
        masks = dev_priv->irq_masks;
-       cur_irq += real_irq;
+       cur_irq = dev_priv->via_irqs + real_irq;
 
        if (masks[real_irq][2] && !force_sequence) {
                DRM_WAIT_ON(ret, cur_irq->irq_queue, 3 * DRM_HZ,
@@ -257,11 +257,12 @@ void via_driver_irq_preinstall(drm_device_t * dev)
 {
        drm_via_private_t *dev_priv = (drm_via_private_t *) dev->dev_private;
        u32 status;
-       drm_via_irq_t *cur_irq = dev_priv->via_irqs;
+       drm_via_irq_t *cur_irq;
        int i;
 
        DRM_DEBUG("driver_irq_preinstall: dev_priv: %p\n", dev_priv);
        if (dev_priv) {
+               cur_irq = dev_priv->via_irqs;
 
                dev_priv->irq_enable_mask = VIA_IRQ_VBLANK_ENABLE;
                dev_priv->irq_pending_mask = VIA_IRQ_VBLANK_PENDING;
@@ -285,7 +286,7 @@ void via_driver_irq_preinstall(drm_device_t * dev)
                        DRM_DEBUG("Initializing IRQ %d\n", i);
                }
                        
-               dev_priv->last_vblank_valid = 0;
+               dev_priv->last_vblank_valid = 0;
 
                /* Clear VSync interrupt regs */
                status = VIA_READ(VIA_REG_INTERRUPT);
index c0ffc97..96708a3 100644 (file)
 #ifndef _VIA_VERIFIER_H_
 #define _VIA_VERIFIER_H_
 
-typedef enum{
+typedef enum {
        no_sequence = 0, 
        z_address,
        dest_address,
        tex_address
-}drm_via_sequence_t;
+} drm_via_sequence_t;
 
 
 
-typedef struct{
+typedef struct {
        unsigned texture;
        uint32_t z_addr; 
        uint32_t d_addr; 
-        uint32_t t_addr[2][10];
+       uint32_t t_addr[2][10];
        uint32_t pitch[2][10];
        uint32_t height[2][10];
        uint32_t tex_level_lo[2];