Resolved coverity isssues 20/189920/2
authorChakradhar <v.pogiri@samsung.com>
Sat, 22 Sep 2018 09:06:22 +0000 (14:36 +0530)
committerChakradhar <v.pogiri@samsung.com>
Wed, 26 Sep 2018 12:40:16 +0000 (18:10 +0530)
Change-Id: If6fa903b55dbd314849fddeb1503c7521314f357
Signed-off-by: Chakradhar <v.pogiri@samsung.com>
framework/deliver-handler/MsgDeliverHandler.cpp
manager/src/msg-manager-notification.cpp

index c87d802..0ffeca5 100755 (executable)
@@ -248,7 +248,8 @@ msg_error_t MsgHandleIncomingMsg(MSG_MESSAGE_INFO_S *pMsgInfo, bool *pSendNoti)
        }
 
        int activated_conv_id = -1;
-       MsgSettingGetInt(VCONFKEY_MESSAGE_ACTIVATED_CONVERSATION_ID, &activated_conv_id);
+       if (MsgSettingGetInt(VCONFKEY_MESSAGE_ACTIVATED_CONVERSATION_ID, &activated_conv_id) != MSG_SUCCESS)
+               MSG_ERR("MsgSettingGetInt() is failed");
 
        if (activated_conv_id > 0 && (unsigned int)activated_conv_id == pMsgInfo->threadId) {
                MSG_WARN("Update message read status of current activated thread. [%d]", pMsgInfo->threadId);
index 909a0d6..3a9ec57 100644 (file)
@@ -1374,7 +1374,11 @@ int MsgMgrInsertDeliveryReportInstantNotification(msg_mgr_notification_type_t no
        MSG_MGR_BEGIN();
 
        notification_h noti = notification_create(NOTIFICATION_TYPE_NOTI);
-       notification_set_pkgname(noti, _get_app_id());
+       int noti_err = notification_set_pkgname(noti, _get_app_id());
+
+       if(noti_err != NOTIFICATION_ERROR_NONE){
+               MSG_MGR_ERR("Fail to notification_set_pkgname : %d", noti_err);
+       }
 
        setTextDomain(noti);
        setNotiText(noti, NOTIFICATION_TEXT_TYPE_TITLE, "Delivery report", DELIVERY_MESSAGE);