radeonsi: always return void from si_build_wrapper_function
authorMarek Olšák <marek.olsak@amd.com>
Sat, 14 Nov 2020 05:59:56 +0000 (00:59 -0500)
committerMarge Bot <eric+marge@anholt.net>
Mon, 23 Nov 2020 02:22:21 +0000 (02:22 +0000)
It's the end of the shader, there are no return values.

Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7623>

src/gallium/drivers/radeonsi/si_shader_llvm.c

index d327e8a..3a69d1d 100644 (file)
@@ -732,9 +732,6 @@ void si_build_wrapper_function(struct si_shader_context *ctx, LLVMValueRef *part
    if (ctx->stage == MESA_SHADER_TESS_CTRL && si_is_multi_part_shader(ctx->shader))
       ac_build_endif(&ctx->ac, 6507);
 
-   /* Return the value from the last part. */
-   if (LLVMGetTypeKind(LLVMTypeOf(ret)) == LLVMVoidTypeKind)
-      LLVMBuildRetVoid(builder);
-   else
-      LLVMBuildRet(builder, ret);
+   assert(LLVMGetTypeKind(LLVMTypeOf(ret)) == LLVMVoidTypeKind);
+   LLVMBuildRetVoid(builder);
 }