[lldbsuite] Un-xfail tests on Windows that are now passing (pt.2)
authorStella Stamenova <stilis@microsoft.com>
Wed, 19 Dec 2018 19:10:25 +0000 (19:10 +0000)
committerStella Stamenova <stilis@microsoft.com>
Wed, 19 Dec 2018 19:10:25 +0000 (19:10 +0000)
This is a set of tests that were all marked as failing becuse of pr21765. The bug is not fixed (as in more of the tests that were marked this way are failing), but this set is passing. It is possible that some of them are false positives, but there's a large number of unexpectedly passing tests on Windows, so I am doing a bulk un-xfail to get the buildbot to green.

llvm-svn: 349668

12 files changed:
lldb/packages/Python/lldbsuite/test/expression_command/char/TestExprsChar.py
lldb/packages/Python/lldbsuite/test/expression_command/dont_allow_jit/TestAllowJIT.py
lldb/packages/Python/lldbsuite/test/expression_command/persistent_types/TestNestedPersistentTypes.py
lldb/packages/Python/lldbsuite/test/expression_command/persistent_types/TestPersistentTypes.py
lldb/packages/Python/lldbsuite/test/expression_command/pr35310/TestExprsBug35310.py
lldb/packages/Python/lldbsuite/test/expression_command/radar_9531204/TestPrintfAfterUp.py
lldb/packages/Python/lldbsuite/test/expression_command/radar_9673664/TestExprHelpExamples.py
lldb/packages/Python/lldbsuite/test/expression_command/test/TestExprs.py
lldb/packages/Python/lldbsuite/test/lang/c/strings/TestCStrings.py
lldb/packages/Python/lldbsuite/test/lang/cpp/chained-calls/TestCppChainedCalls.py
lldb/packages/Python/lldbsuite/test/lang/cpp/global_operators/TestCppGlobalOperators.py
lldb/packages/Python/lldbsuite/test/lang/cpp/static_methods/TestCPPStaticMethods.py

index b328ece..a9679b7 100644 (file)
@@ -41,7 +41,6 @@ class ExprCharTestCase(TestBase):
         self.assertTrue(value.GetError().Success())
         self.assertEqual(value.GetValueAsSigned(0), 3)
 
-    @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr21765")
     def test_default_char(self):
         self.do_test()
 
@@ -52,7 +51,6 @@ class ExprCharTestCase(TestBase):
             "powerpc64le",
             "s390x"],
         bugnumber="llvm.org/pr23069")
-    @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr21765")
     def test_signed_char(self):
         self.do_test(dictionary={'CFLAGS_EXTRAS': '-fsigned-char'})
 
@@ -64,7 +62,6 @@ class ExprCharTestCase(TestBase):
             'armv7',
             'armv7k'],
         bugnumber="llvm.org/pr23069, <rdar://problem/28721938>")
-    @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr21765")
     @expectedFailureAll(triple='mips*', bugnumber="llvm.org/pr23069")
     def test_unsigned_char(self):
         self.do_test(dictionary={'CFLAGS_EXTRAS': '-funsigned-char'})
index a39e891..05c6790 100644 (file)
@@ -22,22 +22,18 @@ class TestAllowJIT(TestBase):
     # each debug info format.
     NO_DEBUG_INFO_TESTCASE = True
 
-    @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr21765")
     def test_allow_jit_expr_command(self):
         """Test the --allow-jit command line flag"""
         self.build()
         self.main_source_file = lldb.SBFileSpec("main.c")
         self.expr_cmd_test()
 
-    @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr21765")
     def test_allow_jit_options(self):
         """Test the SetAllowJIT SBExpressionOption setting"""
         self.build()
         self.main_source_file = lldb.SBFileSpec("main.c")
         self.expr_options_test()
 
-        
-
     def setUp(self):
         # Call super's setUp().
         TestBase.setUp(self)
@@ -62,7 +58,7 @@ class TestAllowJIT(TestBase):
                                    "Set a breakpoint here", self.main_source_file)
 
         frame = thread.GetFrameAtIndex(0)
-        
+
         # First make sure we can call the function with the default option set. 
         options = lldb.SBExpressionOptions()
         # Check that the default is to allow JIT:
index f4ee1b0..8630d6f 100644 (file)
@@ -17,7 +17,6 @@ class NestedPersistentTypesTestCase(TestBase):
 
     mydir = TestBase.compute_mydir(__file__)
 
-    @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr21765")
     def test_persistent_types(self):
         """Test that nested persistent types work."""
         self.build()
index f56cb11..403d242 100644 (file)
@@ -17,7 +17,6 @@ class PersistenttypesTestCase(TestBase):
 
     mydir = TestBase.compute_mydir(__file__)
 
-    @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr21765")
     def test_persistent_types(self):
         """Test that lldb persistent types works correctly."""
         self.build()
index dd3d06f..6d019c7 100644 (file)
@@ -16,7 +16,6 @@ class ExprBug35310(TestBase):
         self.main_source = "main.cpp"
         self.main_source_spec = lldb.SBFileSpec(self.main_source)
 
-    @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr21765")
     def test_issue35310(self):
         """Test invoking functions with non-standard linkage names.
 
index c44cb6f..dc8ee77 100644 (file)
@@ -18,7 +18,6 @@ class Radar9531204TestCase(TestBase):
     mydir = TestBase.compute_mydir(__file__)
 
     # rdar://problem/9531204
-    @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr21765")
     def test_expr_commands(self):
         """The evaluating printf(...) after break stop and then up a stack frame."""
         self.build()
index dfef873..d18720c 100644 (file)
@@ -24,7 +24,6 @@ class Radar9673644TestCase(TestBase):
         self.main_source = "main.c"
         self.line = line_number(self.main_source, '// Set breakpoint here.')
 
-    @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr21765")
     def test_expr_commands(self):
         """The following expression commands should just work."""
         self.build()
index 3af7d80..deae7fe 100644 (file)
@@ -102,7 +102,6 @@ class BasicExprCommandsTestCase(TestBase):
         # (const char *) $8 = 0x... "/Volumes/data/lldb/svn/trunk/test/expression_command/test/a.out"
 
     @add_test_categories(['pyapi'])
-    @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr21765")
     def test_evaluate_expression_python(self):
         """Test SBFrame.EvaluateExpression() API for evaluating an expression."""
         self.build()
@@ -203,7 +202,6 @@ class BasicExprCommandsTestCase(TestBase):
     # rdar://problem/8686536
     # CommandInterpreter::HandleCommand is stripping \'s from input for
     # WantsRawCommand commands
-    @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr21765")
     def test_expr_commands_can_handle_quotes(self):
         """Throw some expression commands with quotes at lldb."""
         self.build()
index b1c8a5e..597a247 100644 (file)
@@ -11,7 +11,6 @@ class CStringsTestCase(TestBase):
 
     mydir = TestBase.compute_mydir(__file__)
 
-    @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr21765")
     def test_with_run_command(self):
         """Tests that C strings work as expected in expressions"""
         self.build()
index a344c4f..080c051 100644 (file)
@@ -8,7 +8,6 @@ class TestCppChainedCalls(TestBase):
 
     mydir = TestBase.compute_mydir(__file__)
 
-    @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr21765")
     def test_with_run_command(self):
         self.build()
 
index fa68d0a..4ead709 100644 (file)
@@ -49,7 +49,6 @@ class TestCppGlobalOperators(TestBase):
 
         return thread.GetSelectedFrame()
 
-    @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr21765")
     def test_equals_operator(self):
         frame = self.prepare_executable_and_get_frame()
 
@@ -87,7 +86,6 @@ class TestCppGlobalOperators(TestBase):
         self.assertTrue(got_type.IsPointerType())
         self.assertEqual(got_type.GetPointeeType().GetName(), "Struct")
 
-    @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr21765")
     def test_operator_new(self):
         frame = self.prepare_executable_and_get_frame()
 
index 404ef22..4b42267 100644 (file)
@@ -16,7 +16,6 @@ class CPPStaticMethodsTestCase(TestBase):
         TestBase.setUp(self)
         self.line = line_number('main.cpp', '// Break at this line')
 
-    @expectedFailureAll(oslist=["windows"])
     def test_with_run_command(self):
         """Test that static methods are properly distinguished from regular methods"""
         self.build()