upgrade-scripts: Fix to invoke as an error when untar fails 33/300633/1
authorSangYoun Kwak <sy.kwak@samsung.com>
Fri, 13 Oct 2023 11:15:22 +0000 (20:15 +0900)
committerSangYoun Kwak <sy.kwak@samsung.com>
Mon, 30 Oct 2023 08:49:10 +0000 (17:49 +0900)
Previously, if the untaring of any delta file from the delta.tar.gz
fails, then the script ignored it and continued to the next delta file.
This may cause some delta files to be not applied which causes the
failure of the FOTA as a result.
To prevent this, the log message was changed to 'Error' from 'Info" and
'exit_error' was used instead of 'continue'.

Change-Id: Idffe1387a58b9a358f717bae4a334405b8946da4
Signed-off-by: SangYoun Kwak <sy.kwak@samsung.com>
scripts/upgrade-support/upgrade-common.inc

index 2829dc34f34182a4b9794cf31bdad9c2c39f9a88..e11a0cf7788895e0d80ac104f045de4f3d6e9dd5 100644 (file)
@@ -206,8 +206,8 @@ upgrade_images() {
                fi
 
                if ! /bin/tar tf "$DELTA_TAR" "$DELTA_NAME"; then
-                       flog "[Info] There is no delta $DELTA_NAME for label $LABEL_NAME from part $PART_NAME"
-                       continue
+                       flog "[Error] There is no delta $DELTA_NAME for label $LABEL_NAME from part $PART_NAME"
+                       exit_error
                fi
 
                local NEXT_PARTITION="$(/usr/bin/blkid-print "$EMMC_DEVICE" "$PART_NAME" "$NEXT_AB" |\