[Coverity] Fix coverity issues

This PR resolves coverity issues of use of auto that causes a copy and missing lock.

**Self-evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test:   [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Donghyeon Jeong <dhyeon.jeong@samsung.com>

diff --git a/api/capi/src/nntrainer.cpp b/api/capi/src/nntrainer.cpp
index 79a2ab77e1169da6d9e724cee120622d6a8a5ce5..5fb77f139d3d1ffded0ea4c6e5a438f06031270d 100644 (file)
--- a/api/capi/src/nntrainer.cpp
+++ b/api/capi/src/nntrainer.cpp
@@ -189,7 +189,7 @@ static int ml_train_dataset_create(ml_train_dataset_h *dataset,
 template <typename... Args>
 static int ml_train_dataset_add_(ml_train_dataset_h dataset,
                                  ml_train_dataset_mode_e mode,
-                                 ml::train::DatasetType type, Args &&... args) {
+                                 ml::train::DatasetType type, Args &&...args) {
   check_feature_state();
   std::shared_ptr<ml::train::Dataset> underlying_dataset;
 
@@ -412,7 +412,6 @@ int ml_train_model_destroy(ml_train_model_h model) {
     ML_TRAIN_RESET_VALIDATED_HANDLE(x.second);
     delete (x.second);
   }
-  nnmodel->layers_map.clear();
 
   delete nnmodel;
 
@@ -785,12 +784,12 @@ int ml_train_optimizer_destroy(ml_train_optimizer_h optimizer) {
   {
     ML_TRAIN_GET_VALID_OPT_LOCKED_RESET(nnopt, optimizer);
     ML_TRAIN_ADOPT_LOCK(nnopt, optimizer_lock);
-  }
 
-  if (nnopt->in_use) {
-    ml_loge("Cannot delete optimizer already set to a model."
-            "Delete model will delete this optimizer.");
-    return ML_ERROR_INVALID_PARAMETER;
+    if (nnopt->in_use) {
+      ml_loge("Cannot delete optimizer already set to a model."
+              "Delete model will delete this optimizer.");
+      return ML_ERROR_INVALID_PARAMETER;
+    }
   }
 
   if (nnopt->lr_scheduler) {

diff --git a/nntrainer/utils/node_exporter.cpp b/nntrainer/utils/node_exporter.cpp
index c8879f260b80a3b4cddcdc8391f25ba0b2e22d11..b0633c1a9892d209aecac7cf72f518208677ad47 100644 (file)
--- a/nntrainer/utils/node_exporter.cpp
+++ b/nntrainer/utils/node_exporter.cpp
@@ -287,7 +287,7 @@ void Exporter::saveTflResult(const std::tuple<props::TargetShape> &props,
   createIfNull(tf_node);
 
   tf_node->setOpType(tflite::BuiltinOperator_RESHAPE);
-  auto targetShape = std::get<props::TargetShape>(props).get();
+  const auto &targetShape = std::get<props::TargetShape>(props).get();
   std::vector<int32_t> new_shape_vec = {
     static_cast<int32_t>(targetShape.batch()),
     static_cast<int32_t>(targetShape.height()),