Remove incorrect warning for parallel implicit firstprivate clause
authorvries <vries@138bc75d-0d04-0410-961f-82ee72b054a4>
Fri, 8 Apr 2016 09:41:16 +0000 (09:41 +0000)
committervries <vries@138bc75d-0d04-0410-961f-82ee72b054a4>
Fri, 8 Apr 2016 09:41:16 +0000 (09:41 +0000)
2016-04-08  Tom de Vries  <tom@codesourcery.com>

* omp-low.c (lower_omp_target): Set TREE_NO_WARNING for oacc
implicit firstprivate clause.

* c-c++-common/goacc/uninit-firstprivate-clause.c: New test.
* gfortran.dg/goacc/uninit-firstprivate-clause.f95: New test.

git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@234826 138bc75d-0d04-0410-961f-82ee72b054a4

gcc/ChangeLog
gcc/omp-low.c
gcc/testsuite/ChangeLog
gcc/testsuite/c-c++-common/goacc/uninit-firstprivate-clause.c [new file with mode: 0644]
gcc/testsuite/gfortran.dg/goacc/uninit-firstprivate-clause.f95 [new file with mode: 0644]

index 7fe1c42..158f4cc 100644 (file)
@@ -1,3 +1,8 @@
+2016-04-08  Tom de Vries  <tom@codesourcery.com>
+
+       * omp-low.c (lower_omp_target): Set TREE_NO_WARNING for oacc
+       implicit firstprivate clause.
+
 2016-04-08  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>
 
        PR target/70566
index 979926d..7105194 100644 (file)
@@ -16077,7 +16077,12 @@ lower_omp_target (gimple_stmt_iterator *gsi_p, omp_context *ctx)
                  {
                    gcc_assert (is_gimple_omp_oacc (ctx->stmt));
                    if (!is_reference (var))
-                     var = build_fold_addr_expr (var);
+                     {
+                       if (is_gimple_reg (var)
+                           && OMP_CLAUSE_FIRSTPRIVATE_IMPLICIT (c))
+                         TREE_NO_WARNING (var) = 1;
+                       var = build_fold_addr_expr (var);
+                     }
                    else
                      talign = TYPE_ALIGN_UNIT (TREE_TYPE (TREE_TYPE (ovar)));
                    gimplify_assign (x, var, &ilist);
index 2668b0d..6ca2610 100644 (file)
@@ -1,3 +1,8 @@
+2016-04-08  Tom de Vries  <tom@codesourcery.com>
+
+       * c-c++-common/goacc/uninit-firstprivate-clause.c: New test.
+       * gfortran.dg/goacc/uninit-firstprivate-clause.f95: New test.
+
 2016-04-08  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>
 
        PR target/70566
diff --git a/gcc/testsuite/c-c++-common/goacc/uninit-firstprivate-clause.c b/gcc/testsuite/c-c++-common/goacc/uninit-firstprivate-clause.c
new file mode 100644 (file)
index 0000000..2584033
--- /dev/null
@@ -0,0 +1,25 @@
+/* { dg-do compile } */
+/* { dg-additional-options "-Wuninitialized" } */
+
+void
+foo (void)
+{
+  int i;
+
+#pragma acc parallel
+  {
+    i = 1;
+  }
+}
+
+
+void
+foo2 (void)
+{
+  int i;
+
+#pragma acc parallel firstprivate (i) /* { dg-warning "is used uninitialized in this function" } */
+  {
+    i = 1;
+  }
+}
diff --git a/gcc/testsuite/gfortran.dg/goacc/uninit-firstprivate-clause.f95 b/gcc/testsuite/gfortran.dg/goacc/uninit-firstprivate-clause.f95
new file mode 100644 (file)
index 0000000..14d960a
--- /dev/null
@@ -0,0 +1,18 @@
+! { dg-do compile }
+! { dg-additional-options "-Wuninitialized" }
+
+subroutine test
+  INTEGER :: i
+
+  !$acc parallel
+  i = 1
+  !$acc end parallel
+end subroutine test
+
+subroutine test2
+  INTEGER :: i
+
+  !$acc parallel firstprivate (i) ! { dg-warning "is used uninitialized in this function" }
+  i = 1
+  !$acc end parallel
+end subroutine test2