agent: Return -EINPROGRESS when request passphrase calls an agent
authorPatrik Flykt <patrik.flykt@linux.intel.com>
Wed, 23 May 2012 12:24:55 +0000 (15:24 +0300)
committerPatrik Flykt <patrik.flykt@linux.intel.com>
Mon, 28 May 2012 07:08:46 +0000 (10:08 +0300)
As a result of returning -EINPROGRESS, the code in service.c can be
simplified.

src/agent.c
src/service.c

index cca9ebc..a9c2a33 100644 (file)
@@ -480,7 +480,7 @@ int __connman_agent_request_passphrase_input(struct connman_service *service,
 
        dbus_message_unref(message);
 
-       return -EIO;
+       return -EINPROGRESS;
 }
 
 int __connman_agent_request_login_input(struct connman_service *service,
index 01e01f2..caecc22 100644 (file)
@@ -5260,10 +5260,8 @@ int __connman_service_connect(struct connman_service *service)
 
        if (service->userconnect == TRUE) {
                if (err == -ENOKEY || err == -EPERM) {
-                       if (__connman_agent_request_passphrase_input(service,
-                                                       request_input_cb,
-                                                       NULL) == -EIO)
-                               return -EINPROGRESS;
+                       return __connman_agent_request_passphrase_input(service,
+                                       request_input_cb, NULL);
                }
                reply_pending(service, -err);
        }