testglib: my_hash_callback_remove_test: actually fail the test
authorSimon McVittie <simon.mcvittie@collabora.co.uk>
Mon, 11 May 2015 15:38:57 +0000 (16:38 +0100)
committerSimon McVittie <simon.mcvittie@collabora.co.uk>
Mon, 11 May 2015 19:24:50 +0000 (20:24 +0100)
The test is to remove all the odd values with my_hash_callback_remove(),
then iterate over all values and verify that they are even. However,
failing this check would just print "bad!" instead of failing the test.

Bug: https://bugzilla.gnome.org/show_bug.cgi?id=725981
Reviewed-by: Colin Walters <walters@verbum.org>
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
tests/testglib.c

index 7ccdc05504c178974d2ddd61f4aa0d6d97df036c..db3ef3e2805153e43e788506ebfe599be1f1896c 100644 (file)
@@ -469,7 +469,7 @@ my_hash_callback_remove_test (gpointer key,
   int *d = value;
 
   if ((*d) % 2)
-    g_print ("bad!\n");
+    g_error ("hash table entry %d should have been removed already\n", *d);
 }
 
 static void