projects
/
platform
/
kernel
/
linux-rpi3.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
52b4c86
)
net/ncsi: Fix length of GVI response packet
author
Gavin Shan
<gwshan@linux.vnet.ibm.com>
Thu, 19 Oct 2017 02:43:09 +0000
(13:43 +1100)
committer
David S. Miller
<davem@davemloft.net>
Sat, 21 Oct 2017 00:56:38 +0000
(
01:56
+0100)
The length of GVI (GetVersionInfo) response packet should be 40 instead
of 36. This issue was found from /sys/kernel/debug/ncsi/eth0/stats.
# ethtool --ncsi eth0 swstats
:
RESPONSE OK TIMEOUT ERROR
=======================================
GVI 0 0 2
With this applied, no error reported on GVI response packets:
# ethtool --ncsi eth0 swstats
:
RESPONSE OK TIMEOUT ERROR
=======================================
GVI 2 0 0
Signed-off-by: Gavin Shan <gwshan@linux.vnet.ibm.com>
Signed-off-by: Samuel Mendoza-Jonas <sam@mendozajonas.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ncsi/ncsi-rsp.c
patch
|
blob
|
history
diff --git
a/net/ncsi/ncsi-rsp.c
b/net/ncsi/ncsi-rsp.c
index
265b9a8
..
927dad4
100644
(file)
--- a/
net/ncsi/ncsi-rsp.c
+++ b/
net/ncsi/ncsi-rsp.c
@@
-959,7
+959,7
@@
static struct ncsi_rsp_handler {
{ NCSI_PKT_RSP_EGMF, 4, ncsi_rsp_handler_egmf },
{ NCSI_PKT_RSP_DGMF, 4, ncsi_rsp_handler_dgmf },
{ NCSI_PKT_RSP_SNFC, 4, ncsi_rsp_handler_snfc },
- { NCSI_PKT_RSP_GVI,
36
, ncsi_rsp_handler_gvi },
+ { NCSI_PKT_RSP_GVI,
40
, ncsi_rsp_handler_gvi },
{ NCSI_PKT_RSP_GC, 32, ncsi_rsp_handler_gc },
{ NCSI_PKT_RSP_GP, -1, ncsi_rsp_handler_gp },
{ NCSI_PKT_RSP_GCPS, 172, ncsi_rsp_handler_gcps },