socket: nullify pointers after free
authorDaniel Mack <daniel@zonque.org>
Tue, 22 Dec 2015 10:32:25 +0000 (11:32 +0100)
committerDaniel Mack <daniel@zonque.org>
Tue, 22 Dec 2015 11:56:33 +0000 (12:56 +0100)
A socket shouldn't be used after socket_done() returns, but follow the
general guideline here and avoid dangling pointers anyway.

src/core/socket.c

index fb7632d..d6b0c96 100644 (file)
@@ -156,14 +156,14 @@ static void socket_done(Unit *u) {
         s->tcp_congestion = mfree(s->tcp_congestion);
         s->bind_to_device = mfree(s->bind_to_device);
 
-        free(s->smack);
-        free(s->smack_ip_in);
-        free(s->smack_ip_out);
+        s->smack = mfree(s->smack);
+        s->smack_ip_in = mfree(s->smack_ip_in);
+        s->smack_ip_out = mfree(s->smack_ip_out);
 
         strv_free(s->symlinks);
 
-        free(s->user);
-        free(s->group);
+        s->user = mfree(s->user);
+        s->group = mfree(s->group);
 
         s->fdname = mfree(s->fdname);