[LLDB][NFC] Fix LLDB_WATCH_TYPE_IS_VALID macro
authorSlava Gurevich <sgurevich@gmail.com>
Tue, 2 Aug 2022 08:33:01 +0000 (01:33 -0700)
committerSlava Gurevich <sgurevich@gmail.com>
Tue, 2 Aug 2022 20:05:29 +0000 (13:05 -0700)
LLDB_WATCH_TYPE_IS_VALID would always return true when validating watchpoint type
by using bitwise-or instead of bitwise-and to apply validation flags.

Differential Revision: https://reviews.llvm.org/D130972

lldb/include/lldb/lldb-defines.h

index 339071b..ad1283b 100644 (file)
@@ -45,7 +45,7 @@
 #define LLDB_WATCH_TYPE_READ (1u << 0)
 #define LLDB_WATCH_TYPE_WRITE (1u << 1)
 #define LLDB_WATCH_TYPE_IS_VALID(type)                                         \
-  ((type | LLDB_WATCH_TYPE_READ) || (type | LLDB_WATCH_TYPE_WRITE))
+  ((type & LLDB_WATCH_TYPE_READ) || (type & LLDB_WATCH_TYPE_WRITE))
 
 // Generic Register Numbers
 #define LLDB_REGNUM_GENERIC_PC 0    // Program Counter