pcmcia: Use common pci_stop_and_remove_bus_device()
authorBjorn Helgaas <bhelgaas@google.com>
Fri, 17 Aug 2012 16:49:04 +0000 (10:49 -0600)
committerBjorn Helgaas <bhelgaas@google.com>
Wed, 22 Aug 2012 17:31:20 +0000 (11:31 -0600)
Use pci_stop_and_remove_bus_device() like most other hotplug drivers
rather than the special-purpose "behind_bridge" variant.  This just
means we have to iterate through all the devices downstream of the
bridge ourselves, which is the same thing pci_stop_behind_bridge()
did.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Acked-by: Yinghai Lu <yinghai@kernel.org>
drivers/pcmcia/cardbus.c

index 24caeaf..9d3ac99 100644 (file)
@@ -105,8 +105,17 @@ int __ref cb_alloc(struct pcmcia_socket *s)
  */
 void cb_free(struct pcmcia_socket *s)
 {
-       struct pci_dev *bridge = s->cb_dev;
+       struct pci_dev *bridge, *dev, *tmp;
+       struct pci_bus *bus;
 
-       if (bridge)
-               pci_stop_and_remove_behind_bridge(bridge);
+       bridge = s->cb_dev;
+       if (!bridge)
+               return;
+
+       bus = bridge->subordinate;
+       if (!bus)
+               return;
+
+       list_for_each_entry_safe(dev, tmp, &bus->devices, bus_list)
+               pci_stop_and_remove_bus_device(dev);
 }