pipe-loader: Do not destroy the winsys on screen creation failure
authorCorentin Noël <corentin.noel@collabora.com>
Wed, 24 May 2023 14:23:35 +0000 (16:23 +0200)
committerMarge Bot <emma+marge@anholt.net>
Tue, 13 Jun 2023 10:10:41 +0000 (10:10 +0000)
The winsys is always destroyed on pipe_loader_device release.

Signed-off-by: Corentin Noël <corentin.noel@collabora.com>
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/9020
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Reviewed-by: Emil Velikov <emil.velikov@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23054>

src/gallium/auxiliary/pipe-loader/pipe_loader_sw.c

index e11837f..829f412 100644 (file)
@@ -424,8 +424,6 @@ pipe_loader_sw_create_screen(struct pipe_loader_device *dev,
    struct pipe_screen *screen;
 
    screen = sdev->dd->create_screen(sdev->ws, config, sw_vk);
-   if (!screen)
-      sdev->ws->destroy(sdev->ws);
 
    return screen ? debug_screen_wrap(screen) : NULL;
 }