drm/radeon: Prefer pr_err/_info over printk
authorSrinivasan Shanmugam <srinivasan.shanmugam@amd.com>
Wed, 19 Jul 2023 11:01:48 +0000 (16:31 +0530)
committerAlex Deucher <alexander.deucher@amd.com>
Fri, 21 Jul 2023 20:52:24 +0000 (16:52 -0400)
Fixes the following checkpatch.pl:

WARNING: printk() should include KERN_<LEVEL> facility level

Cc: Christian König <christian.koenig@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam@amd.com>
Reviewed-by: Guchun Chen <guchun.chen@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/radeon/radeon_atpx_handler.c

index d0b450a..595354e 100644 (file)
@@ -115,7 +115,7 @@ static union acpi_object *radeon_atpx_call(acpi_handle handle, int function,
 
        /* Fail only if calling the method fails and ATPX is supported */
        if (ACPI_FAILURE(status) && status != AE_NOT_FOUND) {
-               printk("failed to evaluate ATPX got %s\n",
+               pr_err("failed to evaluate ATPX got %s\n",
                       acpi_format_exception(status));
                kfree(buffer.pointer);
                return NULL;
@@ -171,7 +171,7 @@ static int radeon_atpx_validate(struct radeon_atpx *atpx)
 
                size = *(u16 *) info->buffer.pointer;
                if (size < 10) {
-                       printk("ATPX buffer is too small: %zu\n", size);
+                       pr_err("ATPX buffer is too small: %zu\n", size);
                        kfree(info);
                        return -EINVAL;
                }
@@ -202,7 +202,7 @@ static int radeon_atpx_validate(struct radeon_atpx *atpx)
 
        atpx->is_hybrid = false;
        if (valid_bits & ATPX_MS_HYBRID_GFX_SUPPORTED) {
-               printk("ATPX Hybrid Graphics\n");
+               pr_info("ATPX Hybrid Graphics\n");
                /*
                 * Disable legacy PM methods only when pcie port PM is usable,
                 * otherwise the device might fail to power off or power on.
@@ -239,7 +239,7 @@ static int radeon_atpx_verify_interface(struct radeon_atpx *atpx)
 
        size = *(u16 *) info->buffer.pointer;
        if (size < 8) {
-               printk("ATPX buffer is too small: %zu\n", size);
+               pr_err("ATPX buffer is too small: %zu\n", size);
                err = -EINVAL;
                goto out;
        }
@@ -248,8 +248,8 @@ static int radeon_atpx_verify_interface(struct radeon_atpx *atpx)
        memcpy(&output, info->buffer.pointer, size);
 
        /* TODO: check version? */
-       printk("ATPX version %u, functions 0x%08x\n",
-              output.version, output.function_bits);
+       pr_info("ATPX version %u, functions 0x%08x\n",
+               output.version, output.function_bits);
 
        radeon_atpx_parse_functions(&atpx->functions, output.function_bits);