projects
/
platform
/
upstream
/
gst-plugins-good.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
324cc4d
)
qtmux: Don't deref NULL pads in debug output
author
Sebastian Dröge
<sebastian@centricular.com>
Wed, 2 Nov 2016 12:33:28 +0000
(14:33 +0200)
committer
Sebastian Dröge
<sebastian@centricular.com>
Wed, 2 Nov 2016 12:33:28 +0000
(14:33 +0200)
That tends to crash.
gst/isomp4/gstqtmux.c
patch
|
blob
|
history
diff --git
a/gst/isomp4/gstqtmux.c
b/gst/isomp4/gstqtmux.c
index
ae78c80
..
b1b4ad9
100644
(file)
--- a/
gst/isomp4/gstqtmux.c
+++ b/
gst/isomp4/gstqtmux.c
@@
-3591,8
+3591,12
@@
find_best_pad (GstQTMux * qtmux, GstCollectPads * pads)
gst_buffer_unref (tmp_buf);
}
- GST_DEBUG_OBJECT (qtmux, "Choosing pad %s:%s",
- GST_DEBUG_PAD_NAME (best_pad->collect.pad));
+ if (best_pad) {
+ GST_DEBUG_OBJECT (qtmux, "Choosing pad %s:%s",
+ GST_DEBUG_PAD_NAME (best_pad->collect.pad));
+ } else {
+ GST_DEBUG_OBJECT (qtmux, "No best pad: EOS");
+ }
}
return best_pad;