s390/lcs: add braces around empty function body
authorHeiko Carstens <hca@linux.ibm.com>
Thu, 18 Nov 2021 16:06:07 +0000 (17:06 +0100)
committerDavid S. Miller <davem@davemloft.net>
Fri, 19 Nov 2021 11:12:30 +0000 (11:12 +0000)
Fix allmodconfig + W=1 compile breakage:

drivers/s390/net/lcs.c: In function ‘lcs_get_frames_cb’:
drivers/s390/net/lcs.c:1823:25: error: suggest braces around empty body in an ‘else’ statement [-Werror=empty-body]
 1823 |                         ; // FIXME: error message ?
      |                         ^

Acked-by: Julian Wiedmann <jwi@linux.ibm.com>
Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
Signed-off-by: Karsten Graul <kgraul@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/s390/net/lcs.c

index 2a64797..a61d38a 100644 (file)
@@ -1808,19 +1808,20 @@ lcs_get_frames_cb(struct lcs_channel *channel, struct lcs_buffer *buffer)
                        return;
                }
                /* What kind of frame is it? */
-               if (lcs_hdr->type == LCS_FRAME_TYPE_CONTROL)
+               if (lcs_hdr->type == LCS_FRAME_TYPE_CONTROL) {
                        /* Control frame. */
                        lcs_get_control(card, (struct lcs_cmd *) lcs_hdr);
-               else if (lcs_hdr->type == LCS_FRAME_TYPE_ENET ||
-                        lcs_hdr->type == LCS_FRAME_TYPE_TR ||
-                        lcs_hdr->type == LCS_FRAME_TYPE_FDDI)
+               else if (lcs_hdr->type == LCS_FRAME_TYPE_ENET ||
+                          lcs_hdr->type == LCS_FRAME_TYPE_TR ||
+                          lcs_hdr->type == LCS_FRAME_TYPE_FDDI) {
                        /* Normal network packet. */
                        lcs_get_skb(card, (char *)(lcs_hdr + 1),
                                    lcs_hdr->offset - offset -
                                    sizeof(struct lcs_header));
-               else
+               } else {
                        /* Unknown frame type. */
                        ; // FIXME: error message ?
+               }
                /* Proceed to next frame. */
                offset = lcs_hdr->offset;
                lcs_hdr->offset = LCS_ILLEGAL_OFFSET;