phy: sunplus: return negative error code in sp_usb_phy_probe
authorSu Hui <suhui@nfschina.com>
Mon, 20 Nov 2023 09:10:47 +0000 (17:10 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 10 Jan 2024 16:16:57 +0000 (17:16 +0100)
[ Upstream commit 2a9c713825b3127ece11984abf973672c9779518 ]

devm_phy_create() return negative error code, 'ret' should be
'PTR_ERR(phy)' rather than '-PTR_ERR(phy)'.

Fixes: 99d9ccd97385 ("phy: usb: Add USB2.0 phy driver for Sunplus SP7021")
Signed-off-by: Su Hui <suhui@nfschina.com>
Link: https://lore.kernel.org/r/20231120091046.163781-1-suhui@nfschina.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/phy/sunplus/phy-sunplus-usb2.c

index 0efe74a..637a5fb 100644 (file)
@@ -275,7 +275,7 @@ static int sp_usb_phy_probe(struct platform_device *pdev)
 
        phy = devm_phy_create(&pdev->dev, NULL, &sp_uphy_ops);
        if (IS_ERR(phy)) {
-               ret = -PTR_ERR(phy);
+               ret = PTR_ERR(phy);
                return ret;
        }