MIPS: BMC47xx: fix kconfig dependency bug for BCM47XX_SSB
authorNecip Fazil Yildiran <fazilyildiran@gmail.com>
Wed, 4 Nov 2020 16:41:27 +0000 (19:41 +0300)
committerThomas Bogendoerfer <tsbogend@alpha.franken.de>
Thu, 12 Nov 2020 22:20:35 +0000 (23:20 +0100)
When BCM47XX_SSB is enabled and SSB_PCIHOST is disabled, it results in the
following Kbuild warning:

WARNING: unmet direct dependencies detected for SSB_B43_PCI_BRIDGE
  Depends on [n]: SSB [=y] && SSB_PCIHOST [=n]
  Selected by [y]:
  - BCM47XX_SSB [=y] && BCM47XX [=y] && PCI [=y]

The reason is that BCM47XX_SSB selects SSB_B43_PCI_BRIDGE without
depending on or selecting SSB_PCIHOST while SSB_B43_PCI_BRIDGE depends on
SSB_PCIHOST. This can also fail building the kernel as demonstrated in a
bug report.

Honor the kconfig dependency to remove unmet direct dependency warnings
and avoid any potential build failures.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=210051
Signed-off-by: Necip Fazil Yildiran <fazilyildiran@gmail.com>
Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
arch/mips/bcm47xx/Kconfig

index 6889f74..4087665 100644 (file)
@@ -9,6 +9,7 @@ config BCM47XX_SSB
        select SSB_DRIVER_MIPS
        select SSB_DRIVER_EXTIF
        select SSB_EMBEDDED
+       select SSB_PCIHOST if PCI
        select SSB_B43_PCI_BRIDGE if PCI
        select SSB_DRIVER_PCICORE if PCI
        select SSB_PCICORE_HOSTMODE if PCI