libbpf: Drop unhelpful "program too large" guess
authorAndrii Nakryiko <andrii@kernel.org>
Tue, 26 Apr 2022 00:45:03 +0000 (17:45 -0700)
committerAlexei Starovoitov <ast@kernel.org>
Tue, 26 Apr 2022 22:41:45 +0000 (15:41 -0700)
libbpf pretends it knows actual limit of BPF program instructions based
on UAPI headers it compiled with. There is neither any guarantee that
UAPI headers match host kernel, nor BPF verifier actually uses
BPF_MAXINSNS constant anymore. Just drop unhelpful "guess", BPF verifier
will emit actual reason for failure in its logs anyways.

Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Link: https://lore.kernel.org/bpf/20220426004511.2691730-3-andrii@kernel.org
tools/lib/bpf/libbpf.c

index cc1a8fc..b8cc862 100644 (file)
@@ -6828,10 +6828,6 @@ retry_load:
                pr_warn("prog '%s': -- BEGIN PROG LOAD LOG --\n%s-- END PROG LOAD LOG --\n",
                        prog->name, log_buf);
        }
-       if (insns_cnt >= BPF_MAXINSNS) {
-               pr_warn("prog '%s': program too large (%d insns), at most %d insns\n",
-                       prog->name, insns_cnt, BPF_MAXINSNS);
-       }
 
 out:
        if (own_log_buf)