projects
/
platform
/
upstream
/
kernel-adaptation-pc.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
2783658
)
asus-wmi: signedness bug in read_brightness()
author
Dan Carpenter
<error27@gmail.com>
Tue, 15 Mar 2011 07:06:23 +0000
(10:06 +0300)
committer
Matthew Garrett
<mjg@redhat.com>
Mon, 28 Mar 2011 10:46:06 +0000
(06:46 -0400)
"err" needs to be signed for the error handling to work.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Matthew Garrett <mjg@redhat.com>
drivers/platform/x86/asus-wmi.c
patch
|
blob
|
history
diff --git
a/drivers/platform/x86/asus-wmi.c
b/drivers/platform/x86/asus-wmi.c
index
5b779a9
..
a038595
100644
(file)
--- a/
drivers/platform/x86/asus-wmi.c
+++ b/
drivers/platform/x86/asus-wmi.c
@@
-946,7
+946,8
@@
static int read_brightness_max(struct asus_wmi *asus)
static int read_brightness(struct backlight_device *bd)
{
struct asus_wmi *asus = bl_get_data(bd);
- u32 retval, err;
+ u32 retval;
+ int err;
err = asus_wmi_get_devstate(asus, ASUS_WMI_DEVID_BRIGHTNESS, &retval);