brcm80211: remove redundant pointer 'address'
authorColin Ian King <colin.king@canonical.com>
Sun, 5 Apr 2020 13:39:06 +0000 (14:39 +0100)
committerKalle Valo <kvalo@codeaurora.org>
Tue, 14 Apr 2020 15:04:55 +0000 (18:04 +0300)
Pointer 'address' is being assigned and updated in a few places
by it is never read. Hence the assignments are redundant and can
be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20200405133906.381358-1-colin.king@canonical.com
drivers/net/wireless/broadcom/brcm80211/brcmfmac/commonring.c

index 49db54d..e44236c 100644 (file)
@@ -180,14 +180,8 @@ again:
 
 int brcmf_commonring_write_complete(struct brcmf_commonring *commonring)
 {
-       void *address;
-
-       address = commonring->buf_addr;
-       address += (commonring->f_ptr * commonring->item_len);
-       if (commonring->f_ptr > commonring->w_ptr) {
-               address = commonring->buf_addr;
+       if (commonring->f_ptr > commonring->w_ptr)
                commonring->f_ptr = 0;
-       }
 
        commonring->f_ptr = commonring->w_ptr;