[lldb] Remove Xfail decorators from steadily passing tests
authorMuhammad Omair Javaid <omair.javaid@linaro.org>
Mon, 9 Dec 2019 14:07:14 +0000 (19:07 +0500)
committerMuhammad Omair Javaid <omair.javaid@linaro.org>
Mon, 9 Dec 2019 14:08:59 +0000 (19:08 +0500)
This patch removes xfail decorator from some lldb testcases which are
passing steadily now for past few week/months on aarch64/linux buildbot.

13 files changed:
lldb/packages/Python/lldbsuite/test/commands/watchpoints/watchpoint_commands/command/TestWatchpointCommandLLDB.py
lldb/packages/Python/lldbsuite/test/commands/watchpoints/watchpoint_commands/command/TestWatchpointCommandPython.py
lldb/packages/Python/lldbsuite/test/commands/watchpoints/watchpoint_commands/condition/TestWatchpointConditionCmd.py
lldb/packages/Python/lldbsuite/test/commands/watchpoints/watchpoint_events/TestWatchpointEvents.py
lldb/packages/Python/lldbsuite/test/functionalities/archives/TestBSDArchives.py
lldb/packages/Python/lldbsuite/test/functionalities/inferior-assert/TestInferiorAssert.py
lldb/packages/Python/lldbsuite/test/functionalities/tail_call_frames/thread_step_out_or_return/TestSteppingOutWithArtificialFrames.py
lldb/packages/Python/lldbsuite/test/functionalities/thread/concurrent_events/TestConcurrentTwoWatchpointsOneSignal.py
lldb/packages/Python/lldbsuite/test/lang/c/const_variables/TestConstVariables.py
lldb/packages/Python/lldbsuite/test/lang/c/global_variables/TestGlobalVariables.py
lldb/packages/Python/lldbsuite/test/python_api/watchpoint/condition/TestWatchpointConditionAPI.py
lldb/packages/Python/lldbsuite/test/tools/lldb-server/TestGdbRemoteSingleStep.py
lldb/packages/Python/lldbsuite/test/tools/lldb-server/TestGdbRemote_vCont.py

index 6be6619..08d220d 100644 (file)
@@ -31,11 +31,6 @@ class WatchpointLLDBCommandTestCase(TestBase):
         self.exe_name = 'a%d.out' % self.test_number
         self.d = {'CXX_SOURCES': self.source, 'EXE': self.exe_name}
 
-    @expectedFailureAll(
-        oslist=["linux"],
-        archs=["aarch64"],
-        triple=no_match(".*-android"),
-        bugnumber="llvm.org/pr27710") # work on android
     def test_watchpoint_command(self):
         """Test 'watchpoint command'."""
         self.build(dictionary=self.d)
@@ -97,11 +92,6 @@ class WatchpointLLDBCommandTestCase(TestBase):
         self.expect("frame variable --show-globals cookie",
                     substrs=['(int32_t)', 'cookie = 777'])
 
-    @expectedFailureAll(
-        oslist=["linux"],
-        archs=["aarch64"],
-        triple=no_match(".*-android"),
-        bugnumber="llvm.org/pr27710") # work on android
     def test_watchpoint_command_can_disable_a_watchpoint(self):
         """Test that 'watchpoint command' action can disable a watchpoint after it is triggered."""
         self.build(dictionary=self.d)
index 57a63b3..b9a67c6 100644 (file)
@@ -33,11 +33,6 @@ class WatchpointPythonCommandTestCase(TestBase):
         self.d = {'CXX_SOURCES': self.source, 'EXE': self.exe_name}
 
     @skipIfFreeBSD  # timing out on buildbot
-    @expectedFailureAll(
-        oslist=["linux"],
-        archs=["aarch64"],
-        triple=no_match(".*-android"),
-        bugnumber="llvm.org/pr27710") # work on android
     def test_watchpoint_command(self):
         """Test 'watchpoint command'."""
         self.build(dictionary=self.d)
@@ -101,11 +96,6 @@ class WatchpointPythonCommandTestCase(TestBase):
                     substrs=['(int32_t)', 'cookie = 777'])
 
     @skipIfFreeBSD  # timing out on buildbot
-    @expectedFailureAll(
-        oslist=["linux"],
-        archs=["aarch64"],
-        triple=no_match(".*-android"),
-        bugnumber="llvm.org/pr27710") # work on android
     def test_continue_in_watchpoint_command(self):
         """Test continue in a watchpoint command."""
         self.build(dictionary=self.d)
index 2a60dfa..e456b2b 100644 (file)
@@ -31,11 +31,6 @@ class WatchpointConditionCmdTestCase(TestBase):
         self.exe_name = self.testMethodName
         self.d = {'CXX_SOURCES': self.source, 'EXE': self.exe_name}
 
-    @expectedFailureAll(
-        oslist=["linux"],
-        archs=["aarch64"],
-        triple=no_match(".*-android"),
-        bugnumber="llvm.org/pr27710")
     def test_watchpoint_cond(self):
         """Test watchpoint condition."""
         self.build(dictionary=self.d)
index 6bd2387..b5bb6c6 100644 (file)
@@ -20,11 +20,6 @@ class TestWatchpointEvents (TestBase):
         self.main_source = "main.c"
 
     @add_test_categories(['pyapi'])
-    @expectedFailureAll(
-        oslist=["linux"],
-        archs=["aarch64"],
-        triple=no_match(".*-android"),
-        bugnumber="llvm.org/pr27710")
     def test_with_python_api(self):
         """Test that adding, deleting and modifying watchpoints sends the appropriate events."""
         self.build()
index eb3eefa..eca71c0 100644 (file)
@@ -23,12 +23,6 @@ class BSDArchivesTestCase(TestBase):
     @expectedFailureAll(
         oslist=["windows"],
         bugnumber="llvm.org/pr24527.  Makefile.rules doesn't know how to build static libs on Windows")
-    @expectedFailureAll(
-        oslist=["linux"],
-        archs=[
-            "arm",
-            "aarch64"],
-        bugnumber="llvm.org/pr27795")
     def test(self):
         """Break inside a() and b() defined within libfoo.a."""
         self.build()
index b2e6dad..36fdc86 100644 (file)
@@ -72,9 +72,7 @@ class AssertingInferiorTestCase(TestBase):
         bugnumber="llvm.org/pr21793: need to implement support for detecting assertion / abort on Windows")
     @expectedFailureAll(
         oslist=["linux"],
-        archs=[
-            "aarch64",
-            "arm"],
+        archs=["arm"],
         triple=no_match(".*-android"),
         bugnumber="llvm.org/pr25338")
     @expectedFailureAll(bugnumber="llvm.org/pr26592", triple='^mips')
@@ -89,9 +87,7 @@ class AssertingInferiorTestCase(TestBase):
         bugnumber="llvm.org/pr21793: need to implement support for detecting assertion / abort on Windows")
     @expectedFailureAll(
         oslist=["linux"],
-        archs=[
-            "aarch64",
-            "arm"],
+        archs=["arm"],
         triple=no_match(".*-android"),
         bugnumber="llvm.org/pr25338")
     @expectedFailureAll(bugnumber="llvm.org/pr26592", triple='^mips')
index 687fb0e..2b432e5 100644 (file)
@@ -71,8 +71,6 @@ class TestArtificialFrameThreadStepOut1(TestBase):
         self.assertFalse(frame2.IsArtificial())
 
     @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr26265")
-    @expectedFailureAll(archs=["aarch64"], oslist=["linux"],
-                        bugnumber="llvm.org/pr44160")
     def test_return_past_artificial_frame(self):
         self.build()
         thread = self.prepare_thread()
index 51260c7..8085937 100644 (file)
@@ -15,7 +15,6 @@ class ConcurrentTwoWatchpointsOneSignal(ConcurrentEventsBase):
     @skipIfFreeBSD  # timing out on buildbot
     # Atomic sequences are not supported yet for MIPS in LLDB.
     @skipIf(triple='^mips')
-    @expectedFailureAll(bugnumber="llvm.org/pr35228", archs=["arm", "aarch64"])
     @expectedFailureNetBSD
     @add_test_categories(["watchpoint"])
     def test(self):
index 5977908..5aacd67 100644 (file)
@@ -25,13 +25,6 @@ class ConstVariableTestCase(TestBase):
     @expectedFailureAll(oslist=["freebsd", "linux"], compiler="icc")
     @expectedFailureAll(archs=['mips', 'mipsel', 'mips64', 'mips64el'])
     @expectedFailureAll(
-        oslist=["linux"],
-        archs=[
-            'arm',
-            'aarch64'],
-        triple=no_match(".*-android"),
-        bugnumber="llvm.org/pr27883")
-    @expectedFailureAll(
         oslist=["windows"],
         bugnumber="llvm.org/pr24489: Name lookup not working correctly on Windows")
     @expectedFailureNetBSD
index 61657e7..4956744 100644 (file)
@@ -22,10 +22,6 @@ class GlobalVariablesTestCase(TestBase):
         self.shlib_names = ["a"]
 
     @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24764")
-    @expectedFailureAll(oslist=["linux"],
-                        archs=["aarch64"],
-                        triple=no_match(".*-android"),
-                        bugnumber="llvm.org/pr37301")
     def test_without_process(self):
         """Test that static initialized variables can be inspected without
         process."""
index a92de23..e6935db 100644 (file)
@@ -31,11 +31,6 @@ class WatchpointConditionAPITestCase(TestBase):
         self.exe_name = self.testMethodName
         self.d = {'CXX_SOURCES': self.source, 'EXE': self.exe_name}
 
-    @expectedFailureAll(
-        oslist=["linux"],
-        archs=["aarch64"],
-        triple=no_match(".*-android"),
-        bugnumber="llvm.org/pr27710")
     def test_watchpoint_cond_api(self):
         """Test watchpoint condition API."""
         self.build(dictionary=self.d)
index 205f49b..f85919a 100644 (file)
@@ -29,9 +29,7 @@ class TestGdbRemoteSingleStep(gdbremote_testcase.GdbRemoteTestCaseBase):
             "aarch64"])
     @expectedFailureAll(
         oslist=["linux"],
-        archs=[
-            "arm",
-            "aarch64"],
+        archs=["arm"],
         bugnumber="llvm.org/pr24739")
     @skipIf(triple='^mips')
     def test_single_step_only_steps_one_instruction_with_s_llgs(self):
index 22265de..bbe2118 100644 (file)
@@ -114,9 +114,7 @@ class TestGdbRemote_vCont(gdbremote_testcase.GdbRemoteTestCaseBase):
             "aarch64"])
     @expectedFailureAll(
         oslist=["linux"],
-        archs=[
-            "arm",
-            "aarch64"],
+        archs=["arm"],
         bugnumber="llvm.org/pr24739")
     @skipIf(triple='^mips')
     @expectedFailureAll(oslist=["ios", "tvos", "watchos", "bridgeos"], bugnumber="rdar://27005337")
@@ -146,9 +144,7 @@ class TestGdbRemote_vCont(gdbremote_testcase.GdbRemoteTestCaseBase):
             "aarch64"])
     @expectedFailureAll(
         oslist=["linux"],
-        archs=[
-            "arm",
-            "aarch64"],
+        archs=["arm"],
         bugnumber="llvm.org/pr24739")
     @skipIf(triple='^mips')
     @expectedFailureAll(oslist=["ios", "tvos", "watchos", "bridgeos"], bugnumber="rdar://27005337")