Off-by-one memory access bugfix.

Terminate on endParsing before dereferencing argEnd.

diff --git a/ncl/ncl.c b/ncl/ncl.c
index 243fd59..bee639a 100644 (file)
--- a/ncl/ncl.c
+++ b/ncl/ncl.c
@@ -164,8 +164,7 @@ static NCLError ncl_prv_split_cmdLine(gchar  *cmdLine, int *iArgc,
        inQuotes = false;
 
        argStart = argEnd = cmdLine;
-       while ((*argc) < NB_MAX_PARAMETERS && *argEnd != '\0' &&
-               endParsing == FALSE) {
+       while (endParsing == FALSE && *argc < NB_MAX_PARAMETERS && *argEnd) {
                while (*argEnd != ' ' && *argEnd != '"' && *argEnd != '\0')
                        argEnd++;
                if (*argEnd == '"') {