projects
/
platform
/
kernel
/
linux-amlogic.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
bff1709
)
net: ieee802154: mcr20a: Use IRQF_NO_AUTOEN flag in request_irq()
author
Jinjie Ruan
<ruanjinjie@huawei.com>
Wed, 11 Sep 2024 09:42:34 +0000
(17:42 +0800)
committer
Stefan Schmidt
<stefan@datenfreihafen.org>
Fri, 27 Sep 2024 08:47:53 +0000
(10:47 +0200)
disable_irq() after request_irq() still has a time gap in which
interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will
disable IRQ auto-enable when request IRQ.
Fixes: 8c6ad9cc5157 ("ieee802154: Add NXP MCR20A IEEE 802.15.4 transceiver driver")
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
Link:
https://lore.kernel.org/20240911094234.1922418-1-ruanjinjie@huawei.com
Signed-off-by: Stefan Schmidt <stefan@datenfreihafen.org>
drivers/net/ieee802154/mcr20a.c
patch
|
blob
|
history
diff --git
a/drivers/net/ieee802154/mcr20a.c
b/drivers/net/ieee802154/mcr20a.c
index 433fb5839203105bd5880e299f3df54d1f084a85..020d392a98b69d3ceeee0ba110b7c10fb1a5690b 100644
(file)
--- a/
drivers/net/ieee802154/mcr20a.c
+++ b/
drivers/net/ieee802154/mcr20a.c
@@
-1302,16
+1302,13
@@
mcr20a_probe(struct spi_device *spi)
irq_type = IRQF_TRIGGER_FALLING;
ret = devm_request_irq(&spi->dev, spi->irq, mcr20a_irq_isr,
- irq_type, dev_name(&spi->dev), lp);
+ irq_type
| IRQF_NO_AUTOEN
, dev_name(&spi->dev), lp);
if (ret) {
dev_err(&spi->dev, "could not request_irq for mcr20a\n");
ret = -ENODEV;
goto free_dev;
}
- /* disable_irq by default and wait for starting hardware */
- disable_irq(spi->irq);
-
ret = ieee802154_register_hw(hw);
if (ret) {
dev_crit(&spi->dev, "ieee802154_register_hw failed\n");