netfilter: nf_tables: underflow in nft_parse_u32_check()
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 12 Oct 2016 09:14:29 +0000 (12:14 +0300)
committerPablo Neira Ayuso <pablo@netfilter.org>
Mon, 17 Oct 2016 15:43:53 +0000 (17:43 +0200)
We don't want to allow negatives here.

Fixes: 36b701fae12a ('netfilter: nf_tables: validate maximum value of u32 netlink attributes')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/netfilter/nf_tables_api.c

index b70d3ea1430e7db49c4a4fc86f87dbb47cfdbe8c..24db22257586bd6b367f200206eaf4b9c36032bd 100644 (file)
@@ -4423,7 +4423,7 @@ static int nf_tables_check_loops(const struct nft_ctx *ctx,
  */
 unsigned int nft_parse_u32_check(const struct nlattr *attr, int max, u32 *dest)
 {
-       int val;
+       u32 val;
 
        val = ntohl(nla_get_be32(attr));
        if (val > max)