Remove unused global state
authorTim Pepper <timothy.c.pepper@linux.intel.com>
Thu, 4 Oct 2012 22:16:37 +0000 (15:16 -0700)
committerTim Pepper <timothy.c.pepper@linux.intel.com>
Thu, 4 Oct 2012 22:16:37 +0000 (15:16 -0700)
Previously this global state needed to be global.  It is essentially unused
now and would have needed locking if it were used.  Simply push it down
into the sole function which uses it now.

Signed-off-by: Tim Pepper <timothy.c.pepper@linux.intel.com>
src/coredump.c
src/corewatcher.h
src/find_file.c

index 3bc7540..ee141e7 100644 (file)
 #include <sys/stat.h>
 #include <sys/time.h>
 #include <dirent.h>
-#include <signal.h>
 #include <glib.h>
 #include <errno.h>
 
 #include "corewatcher.h"
 
-int uid = 0;
-int sig = 0;
-
 const char *core_folder = "/var/lib/corewatcher/";
 const char *processed_folder = "/var/lib/corewatcher/processed/";
 
index d8e1c10..a503d2a 100644 (file)
@@ -76,8 +76,6 @@ extern int scan_corefolders(void * unused);
 extern char *strip_directories(char *fullpath);
 extern char *get_core_filename(char *filename, char *ext);
 extern void remove_name_from_hash(char *fullpath, GHashTable *ht);
-extern int uid;
-extern int sig;
 extern const char *core_folder;
 extern const char *processed_folder;
 
index b04f1af..9760ef7 100644 (file)
@@ -107,6 +107,7 @@ char *find_coredump(char *fullpath)
                if (c) {
                        c += 6;
                        if (c < line_len) {
+                               int uid;
                                sscanf(c, "%i", &uid);
                                fprintf(stderr, "+ uid: %d\n", uid);
                        }
@@ -116,6 +117,7 @@ char *find_coredump(char *fullpath)
                if (c) {
                        c += 8;
                        if (c < line_len) {
+                               int sig;
                                sscanf(c, "%i", &sig);
                                fprintf(stderr, "+ sig: %d\n", sig);
                        }