crypto: hisilicon/qm - replace 'sprintf' with 'scnprintf'
authorWeili Qian <qianweili@huawei.com>
Sat, 31 Oct 2020 09:07:05 +0000 (17:07 +0800)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 6 Nov 2020 03:31:16 +0000 (14:31 +1100)
Replace 'sprintf' with 'scnprintf' to avoid overrun.

Signed-off-by: Weili Qian <qianweili@huawei.com>
Reviewed-by: Zhou Wang <wangzhou1@hisilicon.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/hisilicon/qm.c

index 17f84db..25c5414 100644 (file)
@@ -932,7 +932,8 @@ static ssize_t qm_debug_read(struct file *filp, char __user *buf,
                return -EINVAL;
        }
        mutex_unlock(&file->lock);
-       ret = sprintf(tbuf, "%u\n", val);
+
+       ret = scnprintf(tbuf, QM_DBG_TMP_BUF_LEN, "%u\n", val);
        return simple_read_from_buffer(buf, count, pos, tbuf, ret);
 }